-
Notifications
You must be signed in to change notification settings - Fork 22.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add sandbox attrs to live samples that call prompt()
and confirm()
#38253
Conversation
Preview URLs (6 pages)Flaws (13)Note! 2 documents with no flaws that don't need to be listed. 🎉 URL:
URL:
URL:
URL:
External URLs (2)URL:
URL:
(comment last updated: 2025-02-20 17:16:55) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you.
Only a little suggestion out of respect to ALA :)
Co-authored-by: Vadim Makeev <[email protected]>
Thank you! |
Description
Companion PR of:
Changes:
'allow-modals'
to several live samplesFixes:
Motivation
Making live samples work again.
Related issues and pull requests
Resolves issues in:
allow-modals
yari#12023