Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add sandbox attrs to live samples that call prompt() and confirm() #38253

Merged
merged 10 commits into from
Feb 20, 2025

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented Feb 20, 2025

Description

Companion PR of:

Changes:

  • Add 'allow-modals' to several live samples
  • Minor tidy of code in some live samples

Fixes:

  • Typo in subtlecrypto/derivebits
  • Make "Notes" section more uniform
  • External links in See also

Motivation

Making live samples work again.

Related issues and pull requests

Resolves issues in:

@bsmth bsmth requested review from a team as code owners February 20, 2025 09:27
@bsmth bsmth requested review from sideshowbarker and removed request for a team February 20, 2025 09:27
@github-actions github-actions bot added Content:WebAPI Web API docs Content:Learn Learning area docs size/m [PR only] 51-500 LoC changed labels Feb 20, 2025
Copy link
Contributor

github-actions bot commented Feb 20, 2025

Preview URLs (6 pages)
Flaws (13)

Note! 2 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Learn_web_development/Core/Scripting/Strings
Title: Handling text — strings in JavaScript
Flaw count: 2

  • broken_links:
    • /en-US/docs/Web/API/window/prompt is ill cased
  • macros:
    • Macro produces link /en-US/docs/Web/API/window/prompt which is a redirect

URL: /en-US/docs/Web/API/HTMLTextAreaElement
Title: HTMLTextAreaElement
Flaw count: 1

  • macros:
    • Can't resolve /en-US/docs/Web/API/HTMLTextAreaElement/dirName

URL: /en-US/docs/Web/API/Window/prompt
Title: Window: prompt() method
Flaw count: 4

  • broken_links:
    • /en-US/docs/Web/API/window/alert is ill cased
    • /en-US/docs/Web/API/window/confirm is ill cased
  • macros:
    • Macro produces link /en-US/docs/Web/API/window/alert which is a redirect
    • Macro produces link /en-US/docs/Web/API/window/confirm which is a redirect

URL: /en-US/docs/Web/API/Window/confirm
Title: Window: confirm() method
Flaw count: 6

  • broken_links:
    • /en-US/docs/Web/API/window/open is ill cased
    • /en-US/docs/Web/API/window/alert is ill cased
    • /en-US/docs/Web/API/window/prompt is ill cased
  • macros:
    • Macro produces link /en-US/docs/Web/API/window/open which is a redirect
    • Macro produces link /en-US/docs/Web/API/window/alert which is a redirect
    • Macro produces link /en-US/docs/Web/API/window/prompt which is a redirect
External URLs (2)

URL: /en-US/docs/Web/API/Window/prompt
Title: Window: prompt() method


URL: /en-US/docs/Web/API/Window/confirm
Title: Window: confirm() method

(comment last updated: 2025-02-20 17:16:55)

Copy link
Member

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you.

Only a little suggestion out of respect to ALA :)

@bsmth
Copy link
Member Author

bsmth commented Feb 20, 2025

Thank you!

@bsmth bsmth merged commit b7310d0 into mdn:main Feb 20, 2025
8 checks passed
@bsmth bsmth deleted the window_prompt branch February 20, 2025 17:16
@Josh-Cena Josh-Cena mentioned this pull request Mar 7, 2025
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Learn Learning area docs Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants