Enable modals by adding "allow-modals" to sandbox attribute. #12414
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
see also #12387 mdn/content#38645 |
9 tasks
bsmth
reviewed
Feb 20, 2025
| @@ -100,5 +100,5 @@ if (height) { %> height="<%= height %>"<% } | |||
| %> src="about:blank" data-live-path="<%=env.url%>" data-live-id="<%=id%>"<% | |||
| if (allowedFeatures) { %> allow="<%= allowedFeatures %>"<% } | |||
| if ($token) { %> data-token="<%= JSON.stringify($token) %>"<% } | |||
| %> sandbox="allow-same-origin allow-scripts"></iframe></div><% | |||
| %> sandbox="allow-same-origin allow-scripts allow-modals"></iframe></div><% | |||
There was a problem hiding this comment.
Instead of doing this globally, it's now possible to add these attributes per-example, which is easier to keep track of in terms of usage. See the linked PRs for details.
|
Thanks a lot for the suggestion. I'm going to close this as there is now an alternate method to apply these attributes per-example. See the following PR for more info: And some hints here: https://developer.mozilla.org/en-US/docs/MDN/Writing_guidelines/Page_structures/Live_samples#sandbox Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the
allow-modalsto thesandboxattribute, enabling the playground environment to open modals.Fixes #12023
Problem
Playground examples can't run functions like
window.alert,window.promptand much more because theiframerequires theallow-modalsin the sandbox attribute. Not enablingallow-modalsdoesn't allow any playground which uses modals to be opened, for example this.Solution
This PR adds the
allow-modalsvalue to the sandbox attribute and resolves the issue.Screenshots
Before
After