Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(css): Update live samples calling window.print(), add 'allow-modals' #38232

Merged
merged 8 commits into from
Feb 19, 2025

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented Feb 19, 2025

Description

Update some examples to use allow-modals argument in embedlivesample.

Motivation

Some live samples do not run because of sandbox attributes that are missing.
This gets all instances where we call window.print() in live samples.

Additional details

Pages to fix in this PR:

Related issues and pull requests

Rari release:

Content (macro docs):

Issues:

@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed labels Feb 19, 2025
Copy link
Contributor

github-actions bot commented Feb 19, 2025

Preview URLs

Flaws (8)

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/CSS/@page
Title: @page
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/declaration-rule-list
    • Can't resolve /en-US/docs/Web/CSS/ident-token

URL: /en-US/docs/Web/CSS/@page/page-orientation
Title: page-orientation
Flaw count: 3

  • broken_links:
    • /en-US/docs/Web/CSS/At-rule is a redirect
  • macros:
    • Macro produces link /en-US/docs/Web/CSS/initial_value which is a redirect
    • Macro produces link /en-US/docs/Web/CSS/computed_value which is a redirect

URL: /en-US/docs/Web/CSS/page
Title: page
Flaw count: 3

  • macros:
    • Macro produces link /en-US/docs/Web/CSS/initial_value which is a redirect
    • Macro produces link /en-US/docs/Web/CSS/inheritance which is a redirect
    • Macro produces link /en-US/docs/Web/CSS/computed_value which is a redirect
External URLs (2)

URL: /en-US/docs/Web/CSS/@page
Title: @page

(comment last updated: 2025-02-19 16:33:59)

@bsmth bsmth changed the title feat(css): Update at_page example, add 'allow-modals' feat(css): Update CSS page examples, add 'allow-modals' Feb 19, 2025
@bsmth bsmth marked this pull request as ready for review February 19, 2025 15:45
@bsmth bsmth requested a review from a team as a code owner February 19, 2025 15:45
@bsmth bsmth requested review from estelle and removed request for a team February 19, 2025 15:45
@bsmth bsmth changed the title feat(css): Update CSS page examples, add 'allow-modals' feat(css): Update live samples calling window.print(), add 'allow-modals' Feb 19, 2025
Copy link
Member

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! A few suggestions, otherwise, ready to go 😌 Thanks.

@bsmth
Copy link
Member Author

bsmth commented Feb 19, 2025

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants