-
Notifications
You must be signed in to change notification settings - Fork 22.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(css): Update live samples calling window.print(), add 'allow-modals' #38232
Conversation
Preview URLs
Flaws (8)Note! 1 document with no flaws that don't need to be listed. 🎉 URL:
URL:
URL:
External URLs (2)URL:
(comment last updated: 2025-02-19 16:33:59) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! A few suggestions, otherwise, ready to go 😌 Thanks.
Co-authored-by: Vadim Makeev <[email protected]>
Co-authored-by: Vadim Makeev <[email protected]>
Thank you! |
Description
Update some examples to use
allow-modals
argument inembedlivesample
.Motivation
Some live samples do not run because of
sandbox
attributes that are missing.This gets all instances where we call
window.print()
in live samples.Additional details
Pages to fix in this PR:
Related issues and pull requests
Rari release:
Content (macro docs):
Issues:
allow-modals
yari#12023