glaze: add v5.5.2 #2250
Open
glaze: add v5.5.2 #2250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
drafting because im running into some issues trying to use it locally |
jpakkane
reviewed
Jul 7, 2025
|
|
||
| glaze_dep = declare_dependency( | ||
| include_directories: 'include', | ||
| compile_args: '-std=c++23', |
There was a problem hiding this comment.
This is most definitely not allowed. It is both compiler specific and clashes with the builtin standard version option.
There was a problem hiding this comment.
meson does not support c++23 when specifying a default version, and glaze will not build unless it is on c++23. also, not to mention all standard compilers (llvm, gcc, msvc, etc.) support this flag and the way it's formatted
There was a problem hiding this comment.
He's saying having it a part of glaze_dep
bgilbert
reviewed
Jul 8, 2025
bgilbert
requested changes
Jul 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
couldn't sanity check on my local copy but i tested with gcc on Windows 11 and Ubuntu 13 (WSL)