Skip to content

glaze: add v5.5.2 #2250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

glaze: add v5.5.2 #2250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions releases.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1094,6 +1094,14 @@
"5.2.1-1"
]
},
"glaze": {
"dependency_names": [
"glaze"
],
"versions": [
"5.5.2-1"
]
},
"glbinding": {
"dependency_names": [
"glbinding",
Expand Down
9 changes: 9 additions & 0 deletions subprojects/glaze.wrap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
[wrap-file]
directory = glaze-5.5.2
source_url = https://github.com/stephenberry/glaze/archive/refs/tags/v5.5.2.tar.gz
source_filename = glaze-5.5.2.tar.gz
source_hash = 92382568999829a531db5a3800a36d8699674d640d3862fcb7e79ee2879d95ec
patch_directory = glaze

[provide]
glaze = glaze_dep
11 changes: 11 additions & 0 deletions subprojects/packagefiles/glaze/meson.build
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
project(

Check notice on line 1 in subprojects/packagefiles/glaze/meson.build

View workflow job for this annotation

GitHub Actions / Ubuntu (x86_64)

Minimum Meson version is 0 

No versioned features found.
'glaze',
'cpp',
license: 'MIT',
version: '5.5.2',
)

glaze_dep = declare_dependency(
include_directories: include_directories('include'),
compile_args: '-std=c++23',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is most definitely not allowed. It is both compiler specific and clashes with the builtin standard version option.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meson does not support c++23 when specifying a default version, and glaze will not build unless it is on c++23. also, not to mention all standard compilers (llvm, gcc, msvc, etc.) support this flag and the way it's formatted

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

He's saying having it a part of glaze_dep

)