fmt: properly provide header-only dependency #2379
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic for providing fmts header-only dependency is currently causing problems with building projects targeting WASM. This seems to be because, when the fmt meson option
header-only
is set,fmt_lib
andfmt_dep
are still provided in fmts meson.build file, even though they are not the header-only targets of fmt. The following error message is emitted when trying to build a project using the WASM32/Emscripten backend (even thoughfmt_lib
andfmt_dep
are unused throughout the project):This PR fixes this issue by only providing
fmt_lib
andfmt_dep
whenheader-only
is not set. Whenheader-only
is set, this meson patch only providesfmt_header_only_dep
.Extract from faulty build: