Skip to content

fix ef migration with publish in run mode #17207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebastienros merged 2 commits into from
May 19, 2026
+22 −3
Merged

fix ef migration with publish in run mode #17207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06fdfc2
fix ef migration with publish in run mode
Waleed-KH May 18, 2026
9b09e9c
Add EF migration run-mode pipeline regression test
sebastienros May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Aspire.Hosting.EntityFrameworkCore/EFResourceBuilderExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,8 @@ private static IResourceBuilder<EFMigrationResource> AddEFMigrationsCore(

internal static IEnumerable<PipelineStep> CreateMigrationPipelineStep(PipelineStepFactoryContext context)
{
if (context.Resource is not EFMigrationResource migrationResource
if (context.PipelineContext.ExecutionContext.IsRunMode
|| context.Resource is not EFMigrationResource migrationResource
|| (!migrationResource.PublishAsMigrationScript && !migrationResource.PublishAsMigrationBundle))
{
return [];
Expand Down
22 changes: 20 additions & 2 deletions tests/Aspire.Hosting.EntityFrameworkCore.Tests/EFMigrationPipelineTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,24 @@ public async Task NoPublishOptionsProducesNoSteps()
Assert.Empty(steps);
}

[Fact]
public async Task PublishBundleContainerProducesNoStepsInRunMode()
{
using var builder = TestDistributedApplicationBuilder.Create();
var db = builder.AddResource(new TestDatabaseResource("mydb"));
var project = builder.AddProject<Projects.ServiceA>("myproject");
var migrations = project.AddEFMigrations("mymigrations", typeof(TestDbContext).FullName!)
.WaitFor(db)
.RunDatabaseUpdateOnStart()
.PublishAsMigrationBundle(publishContainer: true);

var steps = await CreateStepsAsync(builder, migrations.Resource);

Assert.Empty(steps);
Assert.True(migrations.Resource.PublishAsMigrationBundle);
Assert.True(migrations.Resource.PublishBundleContainer);
}

[Fact]
public void WaitForConnectionStringResourceAddsWaitAnnotation()
{
Expand Down Expand Up @@ -510,7 +528,7 @@ private static async Task<List<PipelineStep>> CreateStepsAsync(
using var serviceProvider = builder.Services.BuildServiceProvider();
var pipelineContext = new PipelineContext(
serviceProvider.GetRequiredService<DistributedApplicationModel>(),
new DistributedApplicationExecutionContext(DistributedApplicationOperation.Publish),
builder.ExecutionContext,
serviceProvider,
NullLogger.Instance,
CancellationToken.None);
Expand Down Expand Up @@ -553,4 +571,4 @@ private sealed class TestChildDatabaseResource(string name, TestDatabaseResource
public ReferenceExpression ConnectionStringExpression =>
ReferenceExpression.Create($"{Parent};Database={Name}");
}
}
}
Loading