Fixing net_mana crash due to Gdma Error #1154
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erfrimod
force-pushed
the
erfrimod/tx-handle-gdma-error
branch
from
6a7eae2 to
8416b1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After net_mana::tx_poll() receives a CQE of type CQE_TX_GDMA_ERR, it will crash when attempting to pop the front of the posted tx queue. This is because GDMA_ERR is sent from the Hardware to indicate that the queue has been disabled.
tx_poll is running in the context of the ManaQueue, however creating a new tx queue requires access to three resources that are tracked by the ManaEndpoint. So the Vport, ResourceArena, and QueueResources are all provided to the ManaQueue as Weak Arc Mutexes. The Vport was already provided to the ManaQueue in order to retarget VPs.