Skip to content

Fixing net_mana crash due to Gdma Error #1154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fixing net_mana crash due to Gdma Error #1154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions vm/devices/net/gdma_defs/src/bnic.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,7 @@ pub const CQE_TX_VF_DISABLED: u8 = 38;
pub const CQE_TX_VPORT_IDX_OUT_OF_RANGE: u8 = 39;
pub const CQE_TX_VPORT_DISABLED: u8 = 40;
pub const CQE_TX_VLAN_TAGGING_VIOLATION: u8 = 41;
pub const CQE_TX_GDMA_ERR: u8 = 42;

pub const MANA_CQE_COMPLETION: u8 = 1;

Expand Down
40 changes: 39 additions & 1 deletion vm/devices/net/net_mana/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ use gdma_defs::Cqe;
use gdma_defs::GDMA_EQE_COMPLETION;
use gdma_defs::Sge;
use gdma_defs::bnic::CQE_RX_OKAY;
use gdma_defs::bnic::CQE_TX_GDMA_ERR;
use gdma_defs::bnic::CQE_TX_OKAY;
use gdma_defs::bnic::MANA_LONG_PKT_FMT;
use gdma_defs::bnic::MANA_SHORT_PKT_FMT;
Expand Down Expand Up @@ -607,6 +608,7 @@ struct QueueStats {
tx_packets: u64,
tx_errors: u64,
tx_dropped: u64,
tx_stuck: u64,

rx_events: u64,
rx_packets: u64,
Expand All @@ -622,6 +624,7 @@ impl Inspect for QueueStats {
.counter("tx_packets", self.tx_packets)
.counter("tx_errors", self.tx_errors)
.counter("tx_dropped", self.tx_dropped)
.counter("tx_stuck", self.tx_stuck)
.counter("rx_events", self.rx_events)
.counter("rx_packets", self.rx_packets)
.counter("rx_errors", self.rx_errors)
Expand Down Expand Up @@ -718,6 +721,26 @@ impl<T: DeviceBacking> ManaQueue<T> {
false
}
}

fn trace_tx_wqe(&mut self, tx_oob: ManaTxCompOob) {
tracelimit::error_ratelimited!(
cqe_hdr_type = tx_oob.cqe_hdr.cqe_type(),
cqe_hdr_vendor_err = tx_oob.cqe_hdr.vendor_err(),
tx_oob_data_offset = tx_oob.tx_data_offset,
tx_oob_sgl_offset = tx_oob.offsets.tx_sgl_offset(),
tx_oob_wqe_offset = tx_oob.offsets.tx_wqe_offset(),
"tx completion error"
);

if let Some(packet) = self.posted_tx.front() {
tracelimit::error_ratelimited!(
id = packet.id.0,
wqe_len = packet.wqe_len,
bounced_len_with_padding = packet.bounced_len_with_padding,
"posted tx"
);
}
}
}

#[async_trait]
Expand Down Expand Up @@ -903,18 +926,33 @@ impl<T: DeviceBacking + Send> Queue for ManaQueue<T> {

fn tx_poll(&mut self, done: &mut [TxId]) -> anyhow::Result<usize> {
let mut i = 0;
let mut queue_stuck = false;
while i < done.len() {
let id = if let Some(cqe) = self.tx_cq.pop() {
let tx_oob = ManaTxCompOob::read_from_prefix(&cqe.data[..]).unwrap().0; // TODO: zerocopy: use-rest-of-range (https://github.com/microsoft/openvmm/issues/759)
match tx_oob.cqe_hdr.cqe_type() {
CQE_TX_OKAY => {
self.stats.tx_packets += 1;
}
CQE_TX_GDMA_ERR => {
queue_stuck = true;
}
ty => {
tracelimit::error_ratelimited!(ty, "tx completion error");
let vendor_err = tx_oob.cqe_hdr.vendor_err();
tracelimit::error_ratelimited!(ty, vendor_err, "tx completion error");
self.stats.tx_errors += 1;
}
}
if queue_stuck {
// Hardware hit an error with the packet coming from the Guest.
// CQE_TX_GDMA_ERR is how the Hardware indicates that it has disabled the queue.
self.stats.tx_errors += 1;
self.stats.tx_stuck += 1;
self.trace_tx_wqe(tx_oob);
// TODO: attempt to recover by reenabling the queue.
// tracelimit::info_ratelimited!("recreated tx queue");
break;
}
let packet = self.posted_tx.pop_front().unwrap();
self.tx_wq.advance_head(packet.wqe_len);
if packet.bounced_len_with_padding > 0 {
Expand Down