Skip to content

Clone watcher compiler configurations before comparison to prevent unintended recompilation #1197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 16, 2025
Merged

Clone watcher compiler configurations before comparison to prevent unintended recompilation #1197

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
26475e2
Only compare source-file affecting changes in configuration
ephemer Jun 16, 2025
4ce2567
Update internal/execute/watcher.go
ephemer Jun 16, 2025
9008804
Update internal/execute/watcher.go
ephemer Jun 16, 2025
930d5de
Merge branch 'main' into patch-1
ephemer Jun 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion internal/execute/watcher.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,8 @@ func (w *watcher) hasErrorsInTsConfig() bool {
}
return true
}
if !reflect.DeepEqual(w.options.CompilerOptions(), configParseResult.CompilerOptions()) {
// CompilerOptions contain fields which should not be compared; clone to get a copy without those set.
if !reflect.DeepEqual(w.options.CompilerOptions().Clone(), configParseResult.CompilerOptions().Clone()) {
// fmt.Fprint(w.sys.Writer(), "build triggered due to config change", w.sys.NewLine())
w.configModified = true
}
Expand Down