Clone watcher compiler configurations before comparison to prevent unintended recompilation
#1197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging @jakebailey because of his involvement in both #778 and #1156 Also tagging @sheetalkamat because of her involvement in #1078, which appears to be tangentially related to this issue: the difference in configuration appears to come from the cache not being included in one of the configuration objects being compared, while it is included in another. |
jakebailey
reviewed
Jun 16, 2025
jakebailey
reviewed
Jun 16, 2025
Co-authored-by: Jake Bailey <[email protected]>
ephemer
changed the title
watcher compiler configurations before comparison to prevent unintended recompilation
jakebailey
reviewed
Jun 16, 2025
DanielRosenwasser
approved these changes
Jun 16, 2025
Co-authored-by: Jake Bailey <[email protected]>
|
Hi @DanielRosenwasser thanks for your review. I just updated the PR with an additional comment. Could you approve again? |
jakebailey
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the issue reported in #778, #1156 appears to have introduced an issue such that
--watchmode continuously rebuilds a project due to configuration changes, even if no config changes have occurred.This PR aims to address that issue by only comparing the relevant parts of the configuration, while ignoring differences in other parts.
With this change:
Before this change (current
mainbranch):