Added support for ruby 3.4.4 and activesupport 8.0.2#189
Conversation
|
@mkon Can you please review this PR and merge it? |
|
@klausmeyer @mkon Can you please review this PR? |
ja2r.gemspec
Outdated
| s.files = Dir['{app,config,db,lib}/**/*', 'LICENSE', 'README.md'] | ||
|
|
||
| s.add_dependency 'activesupport', '>= 6.1', '< 8.0' | ||
| s.add_dependency 'activesupport', '>= 6.1', '< 9.0' |
There was a problem hiding this comment.
Nit: Personally I would keep it more strict:
| s.add_dependency 'activesupport', '>= 6.1', '< 9.0' | |
| s.add_dependency 'activesupport', '>= 6.1', '< 8.1' |
But up to @mkon ;)
There was a problem hiding this comment.
@mkon changed to 8.1. Please have a look. Thanks
Please don't tag me on future PRs for this gem, as I'm not a maintainer and don't actively use it myself. Thanks! For this one I had a look anyways and would say: LGTM ;) |
|
@nadeemrails91 sorry for the delay, I left a comment. Thanks for taking a look @klausmeyer :) |
I have changed activesupport upper bound to |
|
@0xNadeem can you remove ruby 3.1 from the test matrix and remove it from the supported versions? I think it's old enough and does not work with activesupport 8. |
|
@mkon I have removed ruby 3.1 and its ready to merge. Please have a look. |
|
@0xNadeem thank you for the PR I released new version 0.6.6 with the change. |
4 participants
No description provided.