Skip to content

Added support for ruby 3.4.4 and activesupport 8.0.2 #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkon merged 4 commits into from
Jul 29, 2025
Merged

Added support for ruby 3.4.4 and activesupport 8.0.2 #189

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6a74b56
Added support for ruby 3.4.4 and activesupport 8.0.2
nadeemsbs Jul 17, 2025
b23a2f1
fix: change version
nadeemsbs Jul 21, 2025
5b76e5f
fix: change activesupport upper bound to 8.1
nadeemsbs Jul 24, 2025
041ef23
removed support for ruby 3.1
nadeemsbs Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
strategy:
fail-fast: false
matrix:
activesupport: ['6.1', '7.0', '7.1', '7.2']
activesupport: ['6.1', '7.0', '7.1', '7.2', '8.0']
ruby: ['3.1', '3.2', '3.3', '3.4']
steps:
- uses: actions/checkout@v2
Expand Down
2 changes: 1 addition & 1 deletion .ruby-version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.4.2
3.4.4
2 changes: 1 addition & 1 deletion ja2r.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Gem::Specification.new do |s|

s.files = Dir['{app,config,db,lib}/**/*', 'LICENSE', 'README.md']

s.add_dependency 'activesupport', '>= 6.1', '< 8.0'
s.add_dependency 'activesupport', '>= 6.1', '< 9.0'
Copy link
Contributor

@klausmeyer klausmeyer Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Personally I would keep it more strict:

Suggested change
s.add_dependency 'activesupport', '>= 6.1', '< 9.0'
s.add_dependency 'activesupport', '>= 6.1', '< 8.1'

But up to @mkon ;)

Copy link
Owner

@mkon mkon Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please set 8.1 as upper bound.

Copy link
Contributor Author

@0xNadeem 0xNadeem Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkon changed to 8.1. Please have a look. Thanks


s.metadata['rubygems_mfa_required'] = 'true'
end