Skip to content

Fix incorrect benchmark-set options on app reload #1185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anhappdev merged 1 commit into from
Oct 7, 2026
Merged

Fix incorrect benchmark-set options on app reload #1185

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions flutter/lib/benchmark/benchmark.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,8 +209,10 @@

void applyOptionStateMap(Map<String, bool> inputMap) {
for (final entry in inputMap.entries) {
// FIXME throws on a stored option id missing from the current config.

Check warning on line 212 in flutter/lib/benchmark/benchmark.dart

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

FIXME throws on a stored option id missing from the current config. 


See more on https://sonarcloud.io/project/issues?id=mlcommons_mobile_app_open&issues=AaD766mHcPPQRP7JEDhC&open=AaD766mHcPPQRP7JEDhC&pullRequest=1185
optionSets[optionMap[entry.key]!].setOptionTo(entry.key, entry.value);
}
applyOptions();
}

void applyOptions() {
Expand All @@ -234,6 +236,7 @@
class BenchmarkOptionSet {
final pb.OptionSet config;
late final Map<String, BenchmarkOption> options;
// FIXME stale after construction; min/max_selected check a wrong count.

Check warning on line 239 in flutter/lib/benchmark/benchmark.dart

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

FIXME stale after construction; min/max_selected check a wrong count. 


See more on https://sonarcloud.io/project/issues?id=mlcommons_mobile_app_open&issues=AaD766mHcPPQRP7JEDhD&open=AaD766mHcPPQRP7JEDhD&pullRequest=1185
late int selected;

BenchmarkOptionSet({required this.config}) {
Expand Down
Loading