Repository navigation
Fix incorrect benchmark-set options on app reload - #1185
Merged
Merged
Conversation
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
|
1 task
Contributor
|
let's merge this. @anhappdev please also fix the FIXME part after this one is merged. |
Collaborator
Ok. They should be fixed in #1180. |
anhappdev
added a commit
that referenced
this pull request
Oct 6, 2026
…Android macOS) (#1186) ## Summary The `Build Android app` job in **Android Build & Test (macOS)** fails at `Install dependencies` on every run (e.g. #1185): ``` python@3.14 3.14.7 is already installed but outdated (so it will be upgraded). ... Upgrading python@3.14 dependency: openssl@3 ##[error]The `brew link` step did not complete successfully Could not symlink bin/openssl Target /opt/homebrew/bin/openssl is a symlink belonging to openssl@1.1. ``` The macos-15 runner image creates `/opt/homebrew/bin/openssl -> /opt/homebrew/opt/openssl@1.1/bin/openssl` as a plain symlink that brew does not track. Since python 3.14.8 was published, `brew install python@3.14` upgrades the image's 3.14.7 together with `openssl@3`, whose link collides with that symlink, so `brew install` exits 1. This removes that symlink before the `brew install` lines, only when it points at openssl@1.1. (`brew unlink openssl@1.1` was tried first and removed 0 symlinks, since brew doesn't own the link.) ## Note The `Build iOS app (apple)` / `(tflite)` failures on current PRs are unrelated and not fixable in code: Apple requires the team's Account Holder to accept the updated Program License Agreement (`PLA Update available ... must agree to the latest Program License Agreement`). They will keep failing on this PR too until that's done. ## Test plan - [ ] `Build Android app` in Android Build & Test (macOS) gets past `Install dependencies` and passes on this PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds missing line to properly apply benchmark set options after loading them from preferences (on app reopening)
it supersedes #1180
it includes FIXME notes for a couple other bugs that aren't affecting the app currently, but will if we use min/max or incorrect option ID logic.