Handle unsupported logger types in training logger#463
Open
Ritinikhil wants to merge 1 commit intomllam:mainfrom
Open
Handle unsupported logger types in training logger#463Ritinikhil wants to merge 1 commit intomllam:mainfrom
Ritinikhil wants to merge 1 commit intomllam:mainfrom
Conversation
Raise ValueError for unsupported logger types.
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a bug in setup_training_logger by ensuring unsupported --logger values fail fast with a clear ValueError instead of potentially triggering an UnboundLocalError.
Changes:
- Add an explicit
elsebranch insetup_training_loggerto raise a descriptiveValueErrorfor unsupported logger types. - Restructure the function to return the created logger directly from each supported branch.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+544
to
+548
| else: | ||
| raise ValueError( | ||
| f"Unsupported logger type: {args.logger!r}. " | ||
| "Supported loggers are: 'wandb', 'mlflow'." | ||
| ) |
There was a problem hiding this comment.
Add a unit test asserting that an unsupported args.logger value raises ValueError with a helpful message. There are already setup_training_logger tests in tests/test_cli.py, so extending coverage here will prevent regressions back to an UnboundLocalError/silent misconfiguration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raise ValueError for unsupported logger types.
Describe your changes
elsebranch insetup_training_logger(neural_lam/utils.py) to raise a descriptiveValueErrorwhen an unsupported--loggervalue is provided.UnboundLocalError.Issue Link
closes #206
Type of change
Checklist before requesting a review
Checklist for reviewers
Author checklist after completed review
Checklist for assignee