Skip to content

Handle unsupported logger types in training logger #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ritinikhil wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −2
Open

Handle unsupported logger types in training logger #463

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions neural_lam/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,8 +540,12 @@ def setup_training_logger(datastore, args, run_name):
training_logger.log_hyperparams(
dict(training=vars(args), datastore=datastore._config)
)

return training_logger
return training_logger
else:
raise ValueError(
f"Unsupported logger type: {args.logger!r}. "
"Supported loggers are: 'wandb', 'mlflow'."
)
Comment on lines +544 to +548
Copy link

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a unit test asserting that an unsupported args.logger value raises ValueError with a helpful message. There are already setup_training_logger tests in tests/test_cli.py, so extending coverage here will prevent regressions back to an UnboundLocalError/silent misconfiguration.

Copilot uses AI. Check for mistakes.


def inverse_softplus(x, beta=1, threshold=20):
Expand Down
Loading