Make test_create_decode_mask more specific by validating only m2g edges#104
Open
zweihuehner wants to merge 4 commits intomllam:mainfrom
Open
Make test_create_decode_mask more specific by validating only m2g edges#104zweihuehner wants to merge 4 commits intomllam:mainfrom
zweihuehner wants to merge 4 commits intomllam:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Refines the decode-mask regression test to assert on the intended graph component (m2g decoding edges) rather than total edge count, making the test more future-proof as other components evolve.
Changes:
- Update
test_create_decode_maskto count onlym2gedges when validating filtering behavior. - Adjust the test’s description to match the new, more specific assertion.
- Add a changelog entry describing the test change.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/test_graph_creation.py | Narrows the decode-mask assertion to m2g edges by filtering edges via the component attribute. |
| CHANGELOG.md | Notes the test refinement under Unreleased changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This was referenced Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Updated
test_create_decode_maskto check only m2g (decoding) edges, not total edges. This is done by individually checking the edge components.Focusing the test on
m2gedges ensures it only checks the intended effect of the decode mask, making it independent of edge connectivity ofg2morm2mthat might also usedecode_maskin the future.Issue Link
Solves #103
Type of change
Checklist before requesting a review
pullwith--rebaseoption if possible).Checklist for reviewers
Each PR comes with its own improvements and flaws. The reviewer should check the following:
Author checklist after completed review
reflecting type of change (add section where missing):
Checklist for assignee