Improve specificity of decode_mask test by validating m2g edges#111
Closed
bhawna346 wants to merge 3 commits intomllam:mainfrom
Closed
Improve specificity of decode_mask test by validating m2g edges#111bhawna346 wants to merge 3 commits intomllam:mainfrom
bhawna346 wants to merge 3 commits intomllam:mainfrom
Conversation
Updated edge filtering to retain only edges where both nodes are selected.
bhawna346
changed the title
Add validation to ensure all retained edges satisfy the decode mask.
Add validation for retained edges to satisfy decode mask.
|
Duplicate of #104 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the specificity of the decode_mask test by focusing on the relevant decoding (m2g) edges instead of checking the total number of edges.
Previously, the test verified overall edge count changes, which could lead to vague or misleading validation. This update ensures that only the m2g edges are evaluated, making the test more aligned with the intended behavior and more robust to future changes.
Addresses #103