Skip to content

CSHARP-5788: Replace cake with dotnet cli scripts #1822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2025
Merged

CSHARP-5788: Replace cake with dotnet cli scripts #1822

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion evergreen/build-packages.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ fi
echo Creating nuget package...

dotnet clean ./CSharpDriver.sln
. ./evergreen/compile-sources.sh
./evergreen/compile-sources.sh
Copy link

Copilot AI Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing from sourcing to direct execution means environment variables set in compile-sources.sh will not be available in the current shell. This could break the subsequent dotnet pack command if it depends on variables exported by compile-sources.sh. Verify that no required environment variables are lost.

Suggested change
./evergreen/compile-sources.sh
. ./evergreen/compile-sources.sh

Copilot uses AI. Check for mistakes.
dotnet pack ./CSharpDriver.sln --no-build -o ./artifacts/nuget -c Release -p:Version="$PACKAGE_VERSION" --include-symbols -p:SymbolPackageFormat=snupkg -p:ContinuousIntegrationBuild=true
2 changes: 1 addition & 1 deletion evergreen/evergreen.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -581,7 +581,7 @@ functions:
echo "This platform does not support the ECS auth test, skipping..."
exit 0
fi
. ./evergreen/compile-sources.sh
./evergreen/compile-sources.sh
Copy link

Copilot AI Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing from sourcing to direct execution means environment variables set in compile-sources.sh will not be available in the current shell. The subsequent commands that use $PROJECT_DIRECTORY and $SRC_DIRECTORY may fail if compile-sources.sh sets or modifies these variables. Verify that no required environment variables are lost.

Suggested change
./evergreen/compile-sources.sh
. ./evergreen/compile-sources.sh

Copilot uses AI. Check for mistakes.
echo "Project Directory: $PROJECT_DIRECTORY"
# SRC_DIRECTORY is workaround since EG_TOOLS expects "src" folder as a root
SRC_DIRECTORY=$(dirname $PROJECT_DIRECTORY)/src
Expand Down
2 changes: 1 addition & 1 deletion evergreen/run-atlas-connectivity-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@ set -o errexit # Exit the script with error if any of the commands fail

# Provision the correct connection string and set up SSL if needed
for var in TMP TEMP NUGET_PACKAGES NUGET_HTTP_CACHE_PATH APPDATA; do setx $var z:\\data\\tmp; export $var=z:\\data\\tmp; done
. ./evergreen/compile-sources.sh
./evergreen/compile-sources.sh
Copy link

Copilot AI Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing from sourcing to direct execution means environment variables set in compile-sources.sh will not be available in the current shell. This could break the subsequent build.ps1 execution if it depends on variables exported by compile-sources.sh. Verify that no required environment variables are lost.

Suggested change
./evergreen/compile-sources.sh
. ./evergreen/compile-sources.sh

Copilot uses AI. Check for mistakes.
powershell.exe .\\build.ps1 --target TestAtlasConnectivity
2 changes: 1 addition & 1 deletion evergreen/run-atlas-search-index-helpers-test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,5 @@ echo "Running Atlas Search Index Helpers driver tests"

export ATLAS_SEARCH_INDEX_HELPERS_TESTS_ENABLED=true

. ./evergreen/compile-sources.sh
./evergreen/compile-sources.sh
Copy link

Copilot AI Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing from sourcing to direct execution means environment variables set in compile-sources.sh will not be available in the current shell. This could break the subsequent build.sh execution if it depends on variables exported by compile-sources.sh. Verify that no required environment variables are lost.

Suggested change
./evergreen/compile-sources.sh
source ./evergreen/compile-sources.sh

Copilot uses AI. Check for mistakes.
./build.sh --target=TestAtlasSearchIndexHelpers
2 changes: 1 addition & 1 deletion evergreen/run-atlas-search-test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,5 @@ echo "Running Atlas Search driver tests"

export ATLAS_SEARCH_TESTS_ENABLED=true

. ./evergreen/compile-sources.sh
./evergreen/compile-sources.sh
Copy link

Copilot AI Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing from sourcing to direct execution means environment variables set in compile-sources.sh will not be available in the current shell. This could break the subsequent build.ps1 execution if it depends on variables exported by compile-sources.sh. Verify that no required environment variables are lost.

Suggested change
./evergreen/compile-sources.sh
source ./evergreen/compile-sources.sh

Copilot uses AI. Check for mistakes.
powershell.exe .\\build.ps1 --target=TestAtlasSearch
2 changes: 1 addition & 1 deletion evergreen/run-csfle-azure-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,5 @@ export CSFLE_AZURE_KMS_TESTS_ENABLED=true
export FRAMEWORK=net6.0
. ./evergreen/install-dotnet.sh

. ./evergreen/compile-sources.sh
./evergreen/compile-sources.sh
Copy link

Copilot AI Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing from sourcing to direct execution means environment variables set in compile-sources.sh will not be available in the current shell. This could break the subsequent build.sh execution if it depends on variables exported by compile-sources.sh. Verify that no required environment variables are lost.

Suggested change
./evergreen/compile-sources.sh
. ./evergreen/compile-sources.sh

Copilot uses AI. Check for mistakes.
. ./build.sh --target=TestCsfleWithAzureKms
2 changes: 1 addition & 1 deletion evergreen/run-csfle-gcp-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,5 @@ export CSFLE_GCP_KMS_TESTS_ENABLED=true
export FRAMEWORK=net6.0
. ./evergreen/install-dotnet.sh

. ./evergreen/compile-sources.sh
./evergreen/compile-sources.sh
Copy link

Copilot AI Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing from sourcing to direct execution means environment variables set in compile-sources.sh will not be available in the current shell. This could break the subsequent build.sh execution if it depends on variables exported by compile-sources.sh. Verify that no required environment variables are lost.

Suggested change
./evergreen/compile-sources.sh
. ./evergreen/compile-sources.sh

Copilot uses AI. Check for mistakes.
. ./build.sh --target=TestCsfleWithGcpKms
2 changes: 1 addition & 1 deletion evergreen/run-gssapi-auth-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ if [ "Windows_NT" = "$OS" ]; then
export $var=z:\\data\\tmp
done

. ./evergreen/compile-sources.sh
./evergreen/compile-sources.sh
Copy link

Copilot AI Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing from sourcing to direct execution means environment variables set in compile-sources.sh will not be available in the current shell. This could break the subsequent build.ps1 execution if it depends on variables exported by compile-sources.sh. Verify that no required environment variables are lost.

Suggested change
./evergreen/compile-sources.sh
. ./evergreen/compile-sources.sh

Copilot uses AI. Check for mistakes.
powershell.exe .\\build.ps1 --target TestGssapi
else
echo "Setting krb5 config file"
Expand Down
2 changes: 1 addition & 1 deletion evergreen/run-load-balancer-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,5 +34,5 @@ export MONGODB_URI_WITH_MULTIPLE_MONGOSES=${MULTI_MONGOS_LB_URI}
# show test output
set -x

. ./evergreen/compile-sources.sh
./evergreen/compile-sources.sh
Copy link

Copilot AI Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing from sourcing to direct execution means environment variables set in compile-sources.sh will not be available in the current shell. This could break the subsequent build.sh execution if it depends on variables exported by compile-sources.sh. Verify that no required environment variables are lost.

Suggested change
./evergreen/compile-sources.sh
. ./evergreen/compile-sources.sh

Copilot uses AI. Check for mistakes.
./build.sh --target TestLoadBalanced
2 changes: 1 addition & 1 deletion evergreen/run-mongodb-aws-test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export AWS_TESTS_ENABLED=true
# show test output
set -x

. ./evergreen/compile-sources.sh
./evergreen/compile-sources.sh
Copy link

Copilot AI Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing from sourcing to direct execution means environment variables set in compile-sources.sh will not be available in the current shell. This could break the subsequent build.ps1 or build.sh execution if they depend on variables exported by compile-sources.sh. Given that this PR specifically aims to fix AWS-auth variants, verify that this change doesn't introduce the opposite problem.

Suggested change
./evergreen/compile-sources.sh
. ./evergreen/compile-sources.sh

Copilot uses AI. Check for mistakes.
if [[ "$OS" =~ Windows|windows ]]; then
powershell.exe .\\build.ps1 --target=TestAwsAuthentication
else
Expand Down
2 changes: 1 addition & 1 deletion evergreen/run-mongodb-oidc-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ fi
export OIDC_ENV=$OIDC_ENV
export MONGODB_URI=$MONGODB_URI

. ./evergreen/compile-sources.sh
./evergreen/compile-sources.sh
Copy link

Copilot AI Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing from sourcing to direct execution means environment variables set in compile-sources.sh will not be available in the current shell. This could break the subsequent build.ps1 or build.sh execution if they depend on variables exported by compile-sources.sh. Verify that no required environment variables are lost.

Suggested change
./evergreen/compile-sources.sh
source ./evergreen/compile-sources.sh

Copilot uses AI. Check for mistakes.
if [ "Windows_NT" = "$OS" ]; then
powershell.exe .\\build.ps1 --target "TestMongoDbOidc"
else
Expand Down
2 changes: 1 addition & 1 deletion evergreen/run-plain-auth-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ fi
export MONGODB_URI="${MONGODB_URI}"
export PLAIN_AUTH_TESTS_ENABLED=true

. ./evergreen/compile-sources.sh
./evergreen/compile-sources.sh
Copy link

Copilot AI Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing from sourcing to direct execution means environment variables set in compile-sources.sh will not be available in the current shell. This could break the subsequent build.ps1 or build.sh execution if they depend on variables exported by compile-sources.sh. Verify that no required environment variables are lost.

Suggested change
./evergreen/compile-sources.sh
source ./evergreen/compile-sources.sh

Copilot uses AI. Check for mistakes.
if [[ "$OS" =~ Windows|windows ]]; then
powershell.exe \
'.\build.ps1 --target TestPlainAuthentication'
Expand Down
2 changes: 1 addition & 1 deletion evergreen/run-smoke-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,6 @@ fi
. ./evergreen/append-myget-package-source.sh

export DRIVER_PACKAGE_VERSION="${DRIVER_PACKAGE_VERSION}"
. ./evergreen/compile-sources.sh "$SMOKE_TESTS_PROJECT"
./evergreen/compile-sources.sh "$SMOKE_TESTS_PROJECT"
Copy link

Copilot AI Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing from sourcing to direct execution means environment variables set in compile-sources.sh will not be available in the current shell. If the subsequent dotnet test command relies on variables exported by compile-sources.sh, this change will break the test execution. Verify that compile-sources.sh doesn't set required environment variables.

Suggested change
./evergreen/compile-sources.sh "$SMOKE_TESTS_PROJECT"
. ./evergreen/compile-sources.sh "$SMOKE_TESTS_PROJECT"

Copilot uses AI. Check for mistakes.

dotnet test "$SMOKE_TESTS_PROJECT" -c Release --no-build -f "$FRAMEWORK" --results-directory ./build/test-results --logger "junit;verbosity=detailed;LogFileName=TEST-{assembly}.xml;FailureBodyFormat=Verbose" --logger "console;verbosity=detailed"
2 changes: 1 addition & 1 deletion evergreen/run-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ if [ -f "$DRIVERS_TOOLS/.evergreen/csfle/secrets-export.sh" ]; then
source $DRIVERS_TOOLS/.evergreen/csfle/secrets-export.sh
fi

. ./evergreen/compile-sources.sh
./evergreen/compile-sources.sh
Copy link

Copilot AI Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing from sourcing to direct execution means environment variables set in compile-sources.sh will not be available in the current shell. This could break the subsequent build.ps1 or build.sh execution if they depend on variables exported by compile-sources.sh. Verify that no required environment variables are lost with this change.

Suggested change
./evergreen/compile-sources.sh
source evergreen/compile-sources.sh

Copilot uses AI. Check for mistakes.
if [[ "$OS" =~ Windows|windows ]]; then
powershell.exe .\\build.ps1 --target=$TARGET
else
Expand Down
2 changes: 1 addition & 1 deletion evergreen/run-unit-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,5 @@ if [ "$FRAMEWORK" = "netstandard2.1" ]; then
FRAMEWORK="netcoreapp3.1"
fi

. ./evergreen/compile-sources.sh
./evergreen/compile-sources.sh
Copy link

Copilot AI Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing from sourcing (. ./evergreen/compile-sources.sh) to direct execution (./evergreen/compile-sources.sh) means environment variables set in compile-sources.sh will not be available in the current shell. If compile-sources.sh exports variables needed by the subsequent dotnet test command, those variables will be lost. Verify that compile-sources.sh doesn't set required environment variables, or revert to sourcing.

Suggested change
./evergreen/compile-sources.sh
. ./evergreen/compile-sources.sh

Copilot uses AI. Check for mistakes.
dotnet test -c Release --no-build --filter "Category!=Integration" -f "$FRAMEWORK" --results-directory ./build/test-results --logger "junit;verbosity=detailed;LogFileName=TEST-{assembly}.xml;FailureBodyFormat=Verbose" --logger "console;verbosity=detailed"