CSHARP-5788: Replace cake with dotnet cli scripts #1822
Conversation
sanych-sun
added
the
chore
There was a problem hiding this comment.
Pull request overview
This PR replaces the sourcing (. ./script) of compile-sources.sh with direct execution (./script) across multiple Evergreen CI scripts. The change appears to be part of a broader effort to migrate from Cake build scripts to dotnet CLI scripts, specifically to fix issues with AWS authentication variants.
Key changes:
- Changed script invocation method from sourcing to direct execution for
compile-sources.sh - Modified
compile-sources.shto handle optional project parameter and removed quote wrapping - Added temporary debug output in
run-mongodb-aws-test.sh
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| evergreen/run-unit-tests.sh | Changed from sourcing to executing compile-sources.sh |
| evergreen/run-tests.sh | Changed from sourcing to executing compile-sources.sh |
| evergreen/run-smoke-tests.sh | Changed from sourcing to executing compile-sources.sh |
| evergreen/run-plain-auth-tests.sh | Changed from sourcing to executing compile-sources.sh |
| evergreen/run-mongodb-oidc-tests.sh | Changed from sourcing to executing compile-sources.sh |
| evergreen/run-mongodb-aws-test.sh | Changed from sourcing to executing compile-sources.sh and added debug output |
| evergreen/run-load-balancer-tests.sh | Changed from sourcing to executing compile-sources.sh |
| evergreen/run-gssapi-auth-tests.sh | Changed from sourcing to executing compile-sources.sh |
| evergreen/run-csfle-gcp-tests.sh | Changed from sourcing to executing compile-sources.sh |
| evergreen/run-csfle-azure-tests.sh | Changed from sourcing to executing compile-sources.sh |
| evergreen/run-atlas-search-test.sh | Changed from sourcing to executing compile-sources.sh |
| evergreen/run-atlas-search-index-helpers-test.sh | Changed from sourcing to executing compile-sources.sh |
| evergreen/run-atlas-connectivity-tests.sh | Changed from sourcing to executing compile-sources.sh |
| evergreen/evergreen.yml | Changed from sourcing to executing compile-sources.sh |
| evergreen/compile-sources.sh | Made project parameter optional, removed quotes from variable references, and added debug output |
| evergreen/build-packages.sh | Changed from sourcing to executing compile-sources.sh |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sanych-sun
force-pushed
the
csharp5788
branch
from
841ec47 to
c33ce4c
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 15 out of 15 changed files in this pull request and generated 15 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| fi | ||
|
|
||
| . ./evergreen/compile-sources.sh | ||
| ./evergreen/compile-sources.sh |
There was a problem hiding this comment.
Changing from sourcing (. ./evergreen/compile-sources.sh) to direct execution (./evergreen/compile-sources.sh) means environment variables set in compile-sources.sh will not be available in the current shell. If compile-sources.sh exports variables needed by the subsequent dotnet test command, those variables will be lost. Verify that compile-sources.sh doesn't set required environment variables, or revert to sourcing.
| ./evergreen/compile-sources.sh | |
| . ./evergreen/compile-sources.sh |
| fi | ||
|
|
||
| . ./evergreen/compile-sources.sh | ||
| ./evergreen/compile-sources.sh |
There was a problem hiding this comment.
Changing from sourcing to direct execution means environment variables set in compile-sources.sh will not be available in the current shell. This could break the subsequent build.ps1 or build.sh execution if they depend on variables exported by compile-sources.sh. Verify that no required environment variables are lost with this change.
| ./evergreen/compile-sources.sh | |
| source evergreen/compile-sources.sh |
|
|
||
| export DRIVER_PACKAGE_VERSION="${DRIVER_PACKAGE_VERSION}" | ||
| . ./evergreen/compile-sources.sh "$SMOKE_TESTS_PROJECT" | ||
| ./evergreen/compile-sources.sh "$SMOKE_TESTS_PROJECT" |
There was a problem hiding this comment.
Changing from sourcing to direct execution means environment variables set in compile-sources.sh will not be available in the current shell. If the subsequent dotnet test command relies on variables exported by compile-sources.sh, this change will break the test execution. Verify that compile-sources.sh doesn't set required environment variables.
| ./evergreen/compile-sources.sh "$SMOKE_TESTS_PROJECT" | |
| . ./evergreen/compile-sources.sh "$SMOKE_TESTS_PROJECT" |
| export PLAIN_AUTH_TESTS_ENABLED=true | ||
|
|
||
| . ./evergreen/compile-sources.sh | ||
| ./evergreen/compile-sources.sh |
There was a problem hiding this comment.
Changing from sourcing to direct execution means environment variables set in compile-sources.sh will not be available in the current shell. This could break the subsequent build.ps1 or build.sh execution if they depend on variables exported by compile-sources.sh. Verify that no required environment variables are lost.
| ./evergreen/compile-sources.sh | |
| source ./evergreen/compile-sources.sh |
| export MONGODB_URI=$MONGODB_URI | ||
|
|
||
| . ./evergreen/compile-sources.sh | ||
| ./evergreen/compile-sources.sh |
There was a problem hiding this comment.
Changing from sourcing to direct execution means environment variables set in compile-sources.sh will not be available in the current shell. This could break the subsequent build.ps1 or build.sh execution if they depend on variables exported by compile-sources.sh. Verify that no required environment variables are lost.
| ./evergreen/compile-sources.sh | |
| source ./evergreen/compile-sources.sh |
| export ATLAS_SEARCH_TESTS_ENABLED=true | ||
|
|
||
| . ./evergreen/compile-sources.sh | ||
| ./evergreen/compile-sources.sh |
There was a problem hiding this comment.
Changing from sourcing to direct execution means environment variables set in compile-sources.sh will not be available in the current shell. This could break the subsequent build.ps1 execution if it depends on variables exported by compile-sources.sh. Verify that no required environment variables are lost.
| ./evergreen/compile-sources.sh | |
| source ./evergreen/compile-sources.sh |
| export ATLAS_SEARCH_INDEX_HELPERS_TESTS_ENABLED=true | ||
|
|
||
| . ./evergreen/compile-sources.sh | ||
| ./evergreen/compile-sources.sh |
There was a problem hiding this comment.
Changing from sourcing to direct execution means environment variables set in compile-sources.sh will not be available in the current shell. This could break the subsequent build.sh execution if it depends on variables exported by compile-sources.sh. Verify that no required environment variables are lost.
| ./evergreen/compile-sources.sh | |
| source ./evergreen/compile-sources.sh |
| # Provision the correct connection string and set up SSL if needed | ||
| for var in TMP TEMP NUGET_PACKAGES NUGET_HTTP_CACHE_PATH APPDATA; do setx $var z:\\data\\tmp; export $var=z:\\data\\tmp; done | ||
| . ./evergreen/compile-sources.sh | ||
| ./evergreen/compile-sources.sh |
There was a problem hiding this comment.
Changing from sourcing to direct execution means environment variables set in compile-sources.sh will not be available in the current shell. This could break the subsequent build.ps1 execution if it depends on variables exported by compile-sources.sh. Verify that no required environment variables are lost.
| ./evergreen/compile-sources.sh | |
| . ./evergreen/compile-sources.sh |
| exit 0 | ||
| fi | ||
| . ./evergreen/compile-sources.sh | ||
| ./evergreen/compile-sources.sh |
There was a problem hiding this comment.
Changing from sourcing to direct execution means environment variables set in compile-sources.sh will not be available in the current shell. The subsequent commands that use $PROJECT_DIRECTORY and $SRC_DIRECTORY may fail if compile-sources.sh sets or modifies these variables. Verify that no required environment variables are lost.
| ./evergreen/compile-sources.sh | |
| . ./evergreen/compile-sources.sh |
|
|
||
| dotnet clean ./CSharpDriver.sln | ||
| . ./evergreen/compile-sources.sh | ||
| ./evergreen/compile-sources.sh |
There was a problem hiding this comment.
Changing from sourcing to direct execution means environment variables set in compile-sources.sh will not be available in the current shell. This could break the subsequent dotnet pack command if it depends on variables exported by compile-sources.sh. Verify that no required environment variables are lost.
| ./evergreen/compile-sources.sh | |
| . ./evergreen/compile-sources.sh |
2 participants
Need this changes to fix failed AWS-auth variants