Fix/segment persistent queues #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 13, 2023
Merged
hylkevds
force-pushed
the
fix/segmentPersistentQueues
branch
2 times, most recently
from
41e4f2d to
79e8003
Compare
hylkevds
force-pushed
the
fix/segmentPersistentQueues
branch
2 times, most recently
from
443b067 to
ffdbdf6
Compare
|
@hylkevds please can you fix the conflicts realigning to the current |
Other threads may be reading the same buffer, so we must ensure we have our own reading position and mark.
hylkevds
force-pushed
the
fix/segmentPersistentQueues
branch
from
ffdbdf6 to
dcdab1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on #724, #728 and #722 and contains further fixes from #716: