Fix/add test for segment persistent queues #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 17, 2023
Merged
hylkevds
force-pushed
the
fix/addTestForSegmentPersistentQueues
branch
from
8341efc to
7f6e8d2
Compare
andsel
requested changes
Feb 17, 2023
broker/src/test/java/io/moquette/persistence/SegmentPersistentQueueTest.java
Outdated
Show resolved
Hide resolved
|
|
||
| @BeforeAll | ||
| public static void beforeAll() throws IOException, QueueException { | ||
| System.setProperty("moquette.queue.debug", "false"); |
There was a problem hiding this comment.
It should be already false, because false is the default value when the property is not set.
There was a problem hiding this comment.
True, but when debugging tests it is easier to turn it on when the option is already there. Less searching for what it is called and how to set it.
broker/src/test/java/io/moquette/persistence/SegmentPersistentQueueTest.java
Outdated
Show resolved
Hide resolved
…QueueTest.java Co-authored-by: Andrea Selva <[email protected]>
…QueueTest.java Co-authored-by: Andrea Selva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a test class for the SegmentPersistentQueues.
This builds on #724.
This is followed by #722 and #723.