-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/add test for segment persistent queues #728
Fix/add test for segment persistent queues #728
Conversation
8341efc
to
7f6e8d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of nitpicks, after that it's good to merge
broker/src/test/java/io/moquette/persistence/SegmentPersistentQueueTest.java
Outdated
Show resolved
Hide resolved
|
||
@BeforeAll | ||
public static void beforeAll() throws IOException, QueueException { | ||
System.setProperty("moquette.queue.debug", "false"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be already false, because false is the default value when the property is not set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, but when debugging tests it is easier to turn it on when the option is already there. Less searching for what it is called and how to set it.
broker/src/test/java/io/moquette/persistence/SegmentPersistentQueueTest.java
Outdated
Show resolved
Hide resolved
…QueueTest.java Co-authored-by: Andrea Selva <[email protected]>
…QueueTest.java Co-authored-by: Andrea Selva <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Added a test class for the SegmentPersistentQueues.
This builds on #724.
This is followed by #722 and #723.