Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/add test for segment persistent queues #728

Merged

Conversation

hylkevds
Copy link
Collaborator

Added a test class for the SegmentPersistentQueues.
This builds on #724.
This is followed by #722 and #723.

@andsel
Copy link
Collaborator

andsel commented Feb 17, 2023

Hi @hylkevds, #724 has been merge,please could you rebase this on main ?

@hylkevds hylkevds force-pushed the fix/addTestForSegmentPersistentQueues branch from 8341efc to 7f6e8d2 Compare February 17, 2023 15:00
Copy link
Collaborator

@andsel andsel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of nitpicks, after that it's good to merge


@BeforeAll
public static void beforeAll() throws IOException, QueueException {
System.setProperty("moquette.queue.debug", "false");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be already false, because false is the default value when the property is not set.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, but when debugging tests it is easier to turn it on when the option is already there. Less searching for what it is called and how to set it.

@andsel andsel self-requested a review February 17, 2023 15:36
Copy link
Collaborator

@andsel andsel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andsel andsel merged commit adcf870 into moquette-io:main Feb 17, 2023
@hylkevds hylkevds deleted the fix/addTestForSegmentPersistentQueues branch April 30, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants