-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ensure attached objects update during motion execution #3327
base: main
Are you sure you want to change the base?
fix: ensure attached objects update during motion execution #3327
Conversation
- Check that attached objects in the monitored robot match those in the planned trajectory. - If an object disappears from the monitored robot, remove it from the trajectory waypoint robot_state. - If an object is attached to the monitored robot but missing in the trajectory, add it to enable meaningful collision checking.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3327 +/- ##
==========================================
- Coverage 46.24% 46.22% -0.02%
==========================================
Files 717 717
Lines 62614 62650 +36
Branches 7571 7581 +10
==========================================
+ Hits 28949 28953 +4
- Misses 33498 33530 +32
Partials 167 167 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
style: `sample_attached_object` -> `sample_attached_objects`
…queried based on their consistency in the planned trajectory. --- Before entering the monitoring phase, it checks whether the attached objects remain consistent throughout the trajectory. If they do, they are stored and later used by the isRemainingPathValid method without needing to be queried again. If the attached objects change during the planned trajectory, the map is left empty, signaling isRemainingPathValid to query them at each waypoint.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good to me, with some minor comments!
Also tagged a few other maintainers for a second look.
Hey all, just checking in on this PR. It’s been open for a bit—let me know if I need to update anything to move it forward. |
Description
Implications
This could impact a few different situations: