Adds git clone ros-planning/moveit2.git to install #79
Conversation
| @@ -32,8 +32,9 @@ These tutorials rely on the master branch of MoveIt2, which requires a build fro | |||
| You will need to have a `colcon <https://docs.ros.org/en/foxy/Tutorials/Colcon-Tutorial.html#install-colcon>`_ workspace setup: :: | |||
|
|
|||
| mkdir -p ~/ws_moveit2/src | |||
| cd ~/ws_moveit2/src | |||
|
|
|||
| cd ~/ws_moveit2/src | |||
There was a problem hiding this comment.
Formatting issue in cd ~/ws_moveit2/src : there is a trailing whitespace, which causes CI to fail (see https://github.com/ros-planning/moveit2_tutorials/actions/runs/785001092). Can you please remove the trailing whitespace?
Also as a general comment please try to use pre-commit so you don't have formatting issues (see how to use pre-commit in the README https://github.com/ros-planning/moveit2_tutorials#formatting-and-style).
There was a problem hiding this comment.
Spacing is removed. Thanks @vatanaksoytezer will use pre-commit next time.
There was a problem hiding this comment.
All space-trailing removed.
(did not make a local clone to use pre-commit , hence easily missed when making quick browser edits).
|
@newcanopies Thanks for noticing the missing step and your PR! I left a small comment and will merge right after you update your PR. |
at ln:35 cd ~/ws_moveit2/src
|
Thanks for fixing it. @newcanopies you still have one more trailing whitespace in the empty line (see https://github.com/ros-planning/moveit2_tutorials/pull/79/checks?check_run_id=2437626373). Can you also remove that? |
Description
adds missing step to Foxy source install instructions: moveit/moveit2#438 (comment) @tylerjw
Checklist