Always run the post run step, logging conditionally and exiting based on the success/failure of the run step #23169
+13
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinMind
requested review from
a team and
eviljeff
and removed request for
a team
… on the success/failure of the run step
KevinMind
force-pushed
the
kevinmind/addons/15444
branch
from
0db9014 to
ac8a639
Compare
eviljeff
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: mozilla/addons#15444
Description
Always run the post-run step so that errors from the run step are propogated
Context
We also need to fix the test of this behavior that apparently is false positive currently.
Testing
CI should fail. example
Checklist
#ISSUENUMat the top of your PR to an existing open issue in the mozilla/addons repository.