Always run the post run step, logging conditionally and exiting based on the success/failure of the run step

.github/actions/run-docker/action.yml

@@ -53,13 +53,15 @@ runs:
           ${{ inputs.run }}
         EOF
 
-    - name: Logs
-      if: ${{ inputs.logs }}
+    - name: Post Run (logs and exit code)
+      if: always()
       shell: bash
       run: |
-        docker compose logs
+        if [[ "${{ inputs.logs }}" == "true" ]]; then
+          docker compose logs
+        fi
 
         # If the run command failed, exit with a non-zero exit code
-        if [ ${{ steps.run.outcome }} != 'success' ]; then
+        if [ "${{ steps.run.outcome }}" != 'success' ]; then
           exit 1
         fi

.github/workflows/_test_check.yml

@@ -127,7 +127,6 @@ jobs:
         with:
           digest: ${{ inputs.digest }}
           version: ${{ inputs.version }}
-          logs: true
           run: |
             exit 1
 

src/olympia/amo/management/commands/check_locales_completion_rate.py

@@ -1,16 +1,15 @@
-import hashlib
 import re
 from collections import defaultdict
 
+from django.conf import settings
+from django.core.management.base import BaseCommand
+from django.template import loader
+
 import requests
 from django_statsd.clients import statsd
 from requests.adapters import HTTPAdapter
 from requests.packages.urllib3.util.retry import Retry
 
-from django.conf import settings
-from django.core.management.base import BaseCommand, CommandError
-from django.template import loader
-
 from olympia.amo.utils import send_mail
 from olympia.core.languages import ALL_LANGUAGES
 
@@ -133,7 +132,7 @@ def find_locales_below_and_above_threshold(self):
 
     def fetch_data(self):
         self.stdout.write(
-            f'Calling pontoon with {re.sub(r'\s', '', self.PONTOON_QUERY)}'
+            f'Calling pontoon with {re.sub(r"\s", "", self.PONTOON_QUERY)}'
         )
         session = requests.Session()
         adapter = HTTPAdapter(

src/olympia/amo/tests/test_commands.py

@@ -879,7 +879,7 @@ def _test_full_run_empty_response(self):
             + '\n- '.join(
                 sorted(
                     [
-                        f"{data['english']} [{locale}]"
+                        f'{data["english"]} [{locale}]'
                         for locale, data in settings.AMO_LANGUAGES.items()
                         if locale not in self.expected_special_locales
                         and locale != settings.LANGUAGE_CODE
@@ -896,7 +896,7 @@ def _test_full_run_empty_response(self):
             + '\n- '.join(
                 sorted(
                     [
-                        f"{settings.AMO_LANGUAGES[locale]['english']} [{locale}]"
+                        f'{settings.AMO_LANGUAGES[locale]["english"]} [{locale}]'
                         for locale in self.expected_special_locales
                     ]
                 )