Bug 2026353: Sorting cles by abs value - 0.5#1026
Open
kala-moz wants to merge 1 commit intomozilla:mainfrom
Open
Bug 2026353: Sorting cles by abs value - 0.5#1026kala-moz wants to merge 1 commit intomozilla:mainfrom
kala-moz wants to merge 1 commit intomozilla:mainfrom
Conversation
✅ Deploy Preview for mozilla-perfcompare ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1026 +/- ##
=======================================
Coverage 96.18% 96.18%
=======================================
Files 111 111
Lines 3148 3148
Branches 712 712
=======================================
Hits 3028 3028
Misses 118 118
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for Bug 2026353
Updated the sort function for CLES to subtract 50% or 0.5 since CLES is stored as fractions. Fallback is 0.5, equidistant from 50%. Updated tests to reflect the updated sort.