Skip to content

Bug 2026353: Sorting cles by abs value - 0.5#1026

Open
kala-moz wants to merge 1 commit intomozilla:mainfrom
kala-moz:sorting-cles
Open

Bug 2026353: Sorting cles by abs value - 0.5#1026
kala-moz wants to merge 1 commit intomozilla:mainfrom
kala-moz:sorting-cles

Conversation

@kala-moz
Copy link
Copy Markdown
Contributor

@kala-moz kala-moz commented Apr 8, 2026

Fix for Bug 2026353

Updated the sort function for CLES to subtract 50% or 0.5 since CLES is stored as fractions. Fallback is 0.5, equidistant from 50%. Updated tests to reflect the updated sort.

   sortFunction(
          resultA: MannWhitneyResultsItem,
          resultB: MannWhitneyResultsItem,
        ) {
          return (
            Math.abs((resultA.cles?.cles ?? 0.5) - 0.5) -
            Math.abs((resultB.cles?.cles ?? 0.5) - 0.5)
          );
        },

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 8, 2026

Deploy Preview for mozilla-perfcompare ready!

Name Link
🔨 Latest commit 939db30
🔍 Latest deploy log https://app.netlify.com/projects/mozilla-perfcompare/deploys/69d6d72db1b08e000834cf25
😎 Deploy Preview https://deploy-preview-1026--mozilla-perfcompare.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.18%. Comparing base (b83ad27) to head (939db30).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1026   +/-   ##
=======================================
  Coverage   96.18%   96.18%           
=======================================
  Files         111      111           
  Lines        3148     3148           
  Branches      712      712           
=======================================
  Hits         3028     3028           
  Misses        118      118           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant