Skip to content

Bug 2026353: Sorting cles by abs value - 0.5 #1026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kala-moz wants to merge 1 commit into
base: main
Choose a base branch
from
+33 −33
Open

Bug 2026353: Sorting cles by abs value - 0.5 #1026

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 25 additions & 25 deletions src/__tests__/CompareResults/ResultsTable.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1122,25 +1122,25 @@ describe('Results Table for MannWhitneyResultsItem for mann-whitney-u testVersio
'a11yr dhtml.html opt e10s fission stylo webrender',
' rev: spam',
' - Windows 10, -, , -, , 100.00 %',
' - Windows 10, -2.401 %, , -, , 50.00 %',
' - Linux 18.04, 1.849 %, Regression, -, -, 45.00 %',
' - macOS 10.15, 1.078 %, Improvement, 0.1, -, 25.00 %',
' - Linux 18.04, 1.849 %, Regression, -, -, 45.00 %',
' - Windows 10, -2.401 %, , -, , 50.00 %',
' rev: tictactoe',
' - Windows 10, -, , 0.8, , 99.00 %',
' - Windows 10, -2.401 %, , 0.8, , 49.00 %',
' - Linux 18.04, 1.849 %, Regression, 0.8, -, 44.00 %',
' - macOS 10.15, 1.078 %, Improvement, 0.9, -, 24.00 %',
' - Linux 18.04, 1.849 %, Regression, 0.8, -, 44.00 %',
' - Windows 10, -2.401 %, , 0.8, , 49.00 %',
'a11yr aria.html opt e10s fission stylo webrender',
' rev: spam',
' - Windows 10, -, , 1.2, , 99.00 %',
' - Windows 10, -2.401 %, , 1.2, , 49.00 %',
' - Linux 18.04, 1.849 %, Regression, 1.2, -, 44.00 %',
' - macOS 10.15, 1.078 %, Improvement, 1.3, -, 24.00 %',
' - Linux 18.04, 1.849 %, Regression, 1.2, -, 44.00 %',
' - Windows 10, -2.401 %, , 1.2, , 49.00 %',
' rev: tictactoe',
' - Windows 10, -, , 2, , 98.00 %',
' - Windows 10, -2.401 %, , 2, , 48.00 %',
' - Linux 18.04, 1.849 %, Regression, 2, -, 43.00 %',
' - macOS 10.15, 1.078 %, Improvement, 2.1, -, 23.00 %',
' - Linux 18.04, 1.849 %, Regression, 2, -, 43.00 %',
' - Windows 10, -2.401 %, , 2, , 48.00 %',
]);

expect(effectSizeButton).toMatchSnapshot();
Expand All @@ -1150,28 +1150,28 @@ describe('Results Table for MannWhitneyResultsItem for mann-whitney-u testVersio
// Sort by Effect Size (%) ascending
await user.click(effectSizeButton);
expect(summarizeVisibleRows('mann-whitney-u')).toEqual([
'a11yr aria.html opt e10s fission stylo webrender',
' rev: tictactoe',
' - macOS 10.15, 1.078 %, Improvement, 2.1, -, 23.00 %',
' - Linux 18.04, 1.849 %, Regression, 2, -, 43.00 %',
' - Windows 10, -2.401 %, , 2, , 48.00 %',
' - Windows 10, -, , 2, , 98.00 %',
' rev: spam',
' - macOS 10.15, 1.078 %, Improvement, 1.3, -, 24.00 %',
' - Linux 18.04, 1.849 %, Regression, 1.2, -, 44.00 %',
' - Windows 10, -2.401 %, , 1.2, , 49.00 %',
' - Windows 10, -, , 1.2, , 99.00 %',
'a11yr dhtml.html opt e10s fission stylo webrender',
' rev: spam',
' - Windows 10, -2.401 %, , -, , 50.00 %',
' - Linux 18.04, 1.849 %, Regression, -, -, 45.00 %',
' - macOS 10.15, 1.078 %, Improvement, 0.1, -, 25.00 %',
' - Windows 10, -, , -, , 100.00 %',
' rev: tictactoe',
' - macOS 10.15, 1.078 %, Improvement, 0.9, -, 24.00 %',
' - Linux 18.04, 1.849 %, Regression, 0.8, -, 44.00 %',
' - Windows 10, -2.401 %, , 0.8, , 49.00 %',
' - Linux 18.04, 1.849 %, Regression, 0.8, -, 44.00 %',
' - macOS 10.15, 1.078 %, Improvement, 0.9, -, 24.00 %',
' - Windows 10, -, , 0.8, , 99.00 %',
'a11yr aria.html opt e10s fission stylo webrender',
' rev: spam',
' - macOS 10.15, 1.078 %, Improvement, 0.1, -, 25.00 %',
' - Linux 18.04, 1.849 %, Regression, -, -, 45.00 %',
' - Windows 10, -2.401 %, , -, , 50.00 %',
' - Windows 10, -, , -, , 100.00 %',
' - Windows 10, -2.401 %, , 1.2, , 49.00 %',
' - Linux 18.04, 1.849 %, Regression, 1.2, -, 44.00 %',
' - macOS 10.15, 1.078 %, Improvement, 1.3, -, 24.00 %',
' - Windows 10, -, , 1.2, , 99.00 %',
' rev: tictactoe',
' - Windows 10, -2.401 %, , 2, , 48.00 %',
' - Linux 18.04, 1.849 %, Regression, 2, -, 43.00 %',
' - macOS 10.15, 1.078 %, Improvement, 2.1, -, 23.00 %',
' - Windows 10, -, , 2, , 98.00 %',
]);
expect(effectSizeButton).toMatchSnapshot();
// It should be persisted in the URL
Expand Down
12 changes: 6 additions & 6 deletions src/__tests__/CompareResults/SubtestsResultsView.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -585,11 +585,11 @@ describe('SubtestsResultsView Component Tests for mann-whitney-u testVersion', (
});
await user.click(effectButton);
expect(summarizeVisibleRows('mann-whitney-u')).toEqual([
'browser.html: 0.963 %, -0.04, -, 15.00%',
'regression.html: 1.135 %, 0.12, , 25.00%',
'dhtml.html: 1.135 %, 0.02, , 60.00%',
'improvement.html: 0.963 %, -0.05, , 50.00%',
'tablemutation.html: 0.98 %, 0.01, -, 45.00%',
'regression.html: 1.135 %, 0.12, , 25.00%',
'browser.html: 0.963 %, -0.04, -, 15.00%',
'improvement.html: 0.963 %, -0.05, , 50.00%',
]);

// It should have the "descending" SVG.
Expand All @@ -600,11 +600,11 @@ describe('SubtestsResultsView Component Tests for mann-whitney-u testVersion', (
// Sort by Effect Size ascending
await user.click(effectButton);
expect(summarizeVisibleRows('mann-whitney-u')).toEqual([
'browser.html: 0.963 %, -0.04, -, 15.00%',
'regression.html: 1.135 %, 0.12, , 25.00%',
'tablemutation.html: 0.98 %, 0.01, -, 45.00%',
'improvement.html: 0.963 %, -0.05, , 50.00%',
'tablemutation.html: 0.98 %, 0.01, -, 45.00%',
'dhtml.html: 1.135 %, 0.02, , 60.00%',
'regression.html: 1.135 %, 0.12, , 25.00%',
'browser.html: 0.963 %, -0.04, -, 15.00%',
]);
expectParameterToHaveValue('sort', 'effects|asc');
});
Expand Down
4 changes: 2 additions & 2 deletions src/common/testVersions/mannWhitney.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,8 +205,8 @@ export const mannWhitneyStrategy = {
resultB: MannWhitneyResultsItem,
) {
return (
Math.abs(resultA.cles?.cles ?? 0) -
Math.abs(resultB.cles?.cles ?? 0)
Math.abs((resultA.cles?.cles ?? 0.5) - 0.5) -
Math.abs((resultB.cles?.cles ?? 0.5) - 0.5)
);
},
tooltip: tooltipEffectSize,
Expand Down