Drop support for HOOMD 2 #287
Conversation
|
@mphoward, I took out all the v2 methods and anything isolated under version == 2 check. It seems that all the tests that should pass pass and now our HOOMD 2.9.7 tests fail. Just let me know if you need anything else on this from me! |
|
@mphoward , I've gone through this again. This should have all v3 methods refactored and the imports / version check cleaned up! Just let me know what else this needs! |
mphoward
left a comment
mphoward
left a comment
There was a problem hiding this comment.
Thank you Levi, this is much appreciated! In addition to the minor points here, could you also please add a short discussion on the policy for dropping simulation package versions to the overview of simulate.py. Perhaps after the example?
Co-authored-by: Michael Howard <[email protected]>
|
@mphoward I've addressed your comments so this should be ready for you to take a look at again whenever you have a chance! |
mphoward
left a comment
mphoward
left a comment
There was a problem hiding this comment.
Looks great, thanks! I will apply the one minor thing I noticed then merge.
Addresses Issue #267.
HOOMD 2's last patch release was Aug 3, 2021 well past the 2 year policy decided on in #267.