Skip to content

Drop support for HOOMD 2 #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mphoward merged 19 commits into from
Jan 21, 2025
Merged

Drop support for HOOMD 2 #287

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
166ad9c
Delete anything under a _hoomd_version.major == 2 check.
clpetix Jan 16, 2025
4e5cd73
Delete all call_v2 methods.
clpetix Jan 16, 2025
625e019
Remove other v2 methods.
clpetix Jan 16, 2025
947f75e
Remove HOOMD 2 from tested version.
clpetix Jan 16, 2025
5cf7d07
Remove flags for HOOMD 2 and do a version check.
clpetix Jan 16, 2025
5c5ce2c
Get rid of version >= 3 check.
clpetix Jan 16, 2025
808ff0e
Fix import check.
clpetix Jan 16, 2025
1723954
Consolidate HOOMD version check.
clpetix Jan 16, 2025
fd842e3
Ensure HOOMD version check raises error for versions below 3.x
clpetix Jan 16, 2025
19e02e8
Adjust import logic for Action.
clpetix Jan 16, 2025
0b10b06
Revert change to spoof Action class.
clpetix Jan 16, 2025
e1d5a74
Move version check and consolidate import logic.
clpetix Jan 17, 2025
3ba5671
Remove remaining v3 methods.
clpetix Jan 17, 2025
eb1d8a8
Apply suggestions from code review
clpetix Jan 19, 2025
0d15f91
Update HOOMD doc-string
clpetix Jan 19, 2025
8a32181
Merge branch 'drop/hoomd-2' of https://github.com/mphowardlab/relentl…
clpetix Jan 19, 2025
11eb2a5
Import abc module.
clpetix Jan 19, 2025
4acecc5
Include a discussion on our support policy.
clpetix Jan 20, 2025
8dcbff2
Update .github/workflows/test.yml
mphoward Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,13 +69,10 @@ jobs:
fail-fast: false
matrix:
python-version: ["3.9", "3.10", "3.11"]
hoomd-version: ["2.9.7", "3.11.0", "4.7.0"]
hoomd-version: ["3.11.0", "4.7.0"]
include:
- python-version: "3.12"
hoomd-version: "4.7.0"
exclude:
- python-version: "3.11"
hoomd-version: "2.9.7"
steps:
- name: Checkout code
uses: actions/checkout@v4
Expand All @@ -86,7 +83,7 @@ jobs:
channel-priority: strict
python-version: ${{ matrix.python-version }}
- name: Force HOOMD 2 NumPy version
if: ${{ matrix.hoomd-version == '2.9.7' || matrix.hoomd-version == '3.11.0' }}
if: ${{ matrix.hoomd-version == '3.11.0' }}
run: |
conda install "numpy<2" "gsd<3.4"
- name: Install test dependencies
Expand Down
Loading
Loading