Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed mypy errors #480

Merged
merged 5 commits into from
Feb 10, 2025
Merged

Fixed mypy errors #480

merged 5 commits into from
Feb 10, 2025

Conversation

popenta
Copy link
Collaborator

@popenta popenta commented Feb 7, 2025

No description provided.

@popenta popenta self-assigned this Feb 7, 2025
@popenta popenta marked this pull request as draft February 7, 2025 15:49
Base automatically changed from transaction-refactoring to feat/next February 10, 2025 15:06
@popenta popenta marked this pull request as ready for review February 10, 2025 15:07
raise IncorrectWalletError("Relayer wallet does not match the relayer's address set in the arguments.")

return address_from_account or address_from_args


def _is_matching_address(account_address: Union[Address, None], args_address: Union[Address, None]) -> bool:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment on lines 18 to 19
shards: RegularShards
metashard: Metashard
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe move to constructor?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@popenta popenta merged commit 0f77497 into feat/next Feb 10, 2025
12 checks passed
@popenta popenta deleted the fix-mypy-issues branch February 10, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants