move properties type definition inside constructor

multiversx · popenta · Feb 10, 2025 · Feb 7, 2025 · Feb 10, 2025 · Feb 10, 2025
commit 4062bd23bb5a6e5a91979001fed98d67680dd95e
diff --git a/multiversx_sdk_cli/localnet/config_root.py b/multiversx_sdk_cli/localnet/config_root.py
@@ -15,10 +15,10 @@
 
 
 class ConfigRoot(ConfigPart):
-    shards: RegularShards
-    metashard: Metashard
+    def __init__(self) -> None:
+        self.shards: RegularShards
+        self.metashard: Metashard
 
-    def __init__(self):
         self.general = config_default.general
         self.software = config_default.software
         self.metashard = config_default.metashard

diff --git a/multiversx_sdk_cli/tests/conftest.py b/multiversx_sdk_cli/tests/conftest.py
 import pytest


 # function executed right after test items collected but before test run
diff --git a/multiversx_sdk_cli/tests/test_playground_proxy.py b/multiversx_sdk_cli/tests/test_playground_proxy.py
 import pytest
 import requests


diff --git a/multiversx_sdk_cli/tests/test_native_auth_client.py b/multiversx_sdk_cli/tests/test_native_auth_client.py
 from typing import Any, List

 import pytest

 from multiversx_sdk_cli.native_auth_client import (
    NativeAuthClient,
diff --git a/multiversx_sdk_cli/tests/test_accounts.py b/multiversx_sdk_cli/tests/test_accounts.py
 from pathlib import Path

 import pytest
 from multiversx_sdk import Account


diff --git a/multiversx_sdk_cli/tests/test_contracts.py b/multiversx_sdk_cli/tests/test_contracts.py
 import logging
 from pathlib import Path

 import pytest
 from Cryptodome.Hash import keccak
 from multiversx_sdk import Account, Address, TransactionsFactoryConfig

diff --git a/multiversx_sdk_cli/tests/test_shared.py b/multiversx_sdk_cli/tests/test_shared.py
 from typing import Any

 import pytest

 from multiversx_sdk_cli.cli_shared import prepare_chain_id_in_args
 from multiversx_sdk_cli.errors import ArgumentsNotProvidedError
diff --git a/multiversx_sdk_cli/tests/test_cli_validators.py b/multiversx_sdk_cli/tests/test_cli_validators.py
 from pathlib import Path

 import pytest

 from multiversx_sdk_cli.cli import main

diff --git a/multiversx_sdk_cli/tests/test_cli_deps.py b/multiversx_sdk_cli/tests/test_cli_deps.py
 import pytest

 from multiversx_sdk_cli.cli import main
	import pytest
Check failure on line 1 in multiversx_sdk_cli/tests/conftest.py GitHub Actions / runner / mypy `[mypy] reported by reviewdog 🐶 Cannot find implementation or library stub for module named "pytest" [import-not-found] Raw Output: /home/runner/work/mx-sdk-py-cli/mx-sdk-py-cli/multiversx_sdk_cli/tests/conftest.py:1:1: error: Cannot find implementation or library stub for module named "pytest" [import-not-found]` Check warning on line 1 in multiversx_sdk_cli/tests/conftest.py GitHub Actions / runner / mypy `[mypy] reported by reviewdog 🐶 See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports Raw Output: /home/runner/work/mx-sdk-py-cli/mx-sdk-py-cli/multiversx_sdk_cli/tests/conftest.py:1:1: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports`


	# function executed right after test items collected but before test run
	import pytest
Check failure on line 1 in multiversx_sdk_cli/tests/test_playground_proxy.py GitHub Actions / runner / mypy `[mypy] reported by reviewdog 🐶 Cannot find implementation or library stub for module named "pytest" [import-not-found] Raw Output: /home/runner/work/mx-sdk-py-cli/mx-sdk-py-cli/multiversx_sdk_cli/tests/test_playground_proxy.py:1:1: error: Cannot find implementation or library stub for module named "pytest" [import-not-found]`
	import requests
	from typing import Any, List

	import pytest
Check failure on line 3 in multiversx_sdk_cli/tests/test_native_auth_client.py GitHub Actions / runner / mypy `[mypy] reported by reviewdog 🐶 Cannot find implementation or library stub for module named "pytest" [import-not-found] Raw Output: /home/runner/work/mx-sdk-py-cli/mx-sdk-py-cli/multiversx_sdk_cli/tests/test_native_auth_client.py:3:1: error: Cannot find implementation or library stub for module named "pytest" [import-not-found]`

	from multiversx_sdk_cli.native_auth_client import (
	NativeAuthClient,
	from pathlib import Path

	import pytest
Check failure on line 3 in multiversx_sdk_cli/tests/test_accounts.py GitHub Actions / runner / mypy `[mypy] reported by reviewdog 🐶 Cannot find implementation or library stub for module named "pytest" [import-not-found] Raw Output: /home/runner/work/mx-sdk-py-cli/mx-sdk-py-cli/multiversx_sdk_cli/tests/test_accounts.py:3:1: error: Cannot find implementation or library stub for module named "pytest" [import-not-found]`
	from multiversx_sdk import Account
	import logging
	from pathlib import Path

	import pytest
Check failure on line 4 in multiversx_sdk_cli/tests/test_contracts.py GitHub Actions / runner / mypy `[mypy] reported by reviewdog 🐶 Cannot find implementation or library stub for module named "pytest" [import-not-found] Raw Output: /home/runner/work/mx-sdk-py-cli/mx-sdk-py-cli/multiversx_sdk_cli/tests/test_contracts.py:4:1: error: Cannot find implementation or library stub for module named "pytest" [import-not-found]`
	from Cryptodome.Hash import keccak
	from multiversx_sdk import Account, Address, TransactionsFactoryConfig
	from typing import Any

	import pytest
Check failure on line 3 in multiversx_sdk_cli/tests/test_shared.py GitHub Actions / runner / mypy `[mypy] reported by reviewdog 🐶 Cannot find implementation or library stub for module named "pytest" [import-not-found] Raw Output: /home/runner/work/mx-sdk-py-cli/mx-sdk-py-cli/multiversx_sdk_cli/tests/test_shared.py:3:1: error: Cannot find implementation or library stub for module named "pytest" [import-not-found]`

	from multiversx_sdk_cli.cli_shared import prepare_chain_id_in_args
	from multiversx_sdk_cli.errors import ArgumentsNotProvidedError
	import pytest
Check failure on line 1 in multiversx_sdk_cli/tests/test_cli_deps.py GitHub Actions / runner / mypy `[mypy] reported by reviewdog 🐶 Cannot find implementation or library stub for module named "pytest" [import-not-found] Raw Output: /home/runner/work/mx-sdk-py-cli/mx-sdk-py-cli/multiversx_sdk_cli/tests/test_cli_deps.py:1:1: error: Cannot find implementation or library stub for module named "pytest" [import-not-found]`

	from multiversx_sdk_cli.cli import main