Cumulative Ad playing time #86
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daytime-em
reviewed
Sep 24, 2025
daytime-em
reviewed
Sep 26, 2025
daytime-em
approved these changes
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements tracking of ad watch time and calculation of cumulative watch time (watch time of content + ads and watch time of ads)
Due to not having the possibility of tracking playhead time on ads, the calculation of ad watch time is done using wall clock comparisons, tracking the start and end of the ads and calculating the difference (without taking into account the pauses and rebuffers)
The cumulative time ad is sent as
ad_playing_time_active_ms_cumulativeThe cumulative time of content + ads is sent as
view_playing_time_ms_cumulative