-
Notifications
You must be signed in to change notification settings - Fork 4
Cumulative Ad playing time #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fabrizio-rar
wants to merge
12
commits into
master
Choose a base branch
from
fp/subview-metrics
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
651fb04
initial implementation of ad time tracking
fabrizio-rar 8f76ce0
added ad time tracking for stitched ads
fabrizio-rar adbae52
added total ad watch time tracking
fabrizio-rar bc4eda9
added metrics and shortcodes
fabrizio-rar 79f2011
shortcode change
fabrizio-rar d9b69fc
changed variable inits
fabrizio-rar bb9fbff
changed ad calculations to tie to mux events
fabrizio-rar 464cce5
naming changes
fabrizio-rar 5775a8d
small change for ssai case
fabrizio-rar 89f30bd
added checks for negative adwatchtime values
fabrizio-rar a29e168
fix on playing time for stitched ads
fabrizio-rar f53d562
added watch time reset on impression for ssai
fabrizio-rar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.