Repository navigation
MS19 +2wk for LLC lead time; bind PLAN Target to .ics + guard drift #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,94 @@ | ||
| <?php | ||
|
|
||
| namespace Tests\Feature\Docs; | ||
|
|
||
| use Illuminate\Support\Str; | ||
| use PHPUnit\Framework\Attributes\Group; | ||
| use Tests\TestCase; | ||
|
|
||
| /** | ||
| * Guards the one invariant that kept drifting by hand: every milestone's | ||
| * Target in PLAN.md must equal that milestone's end date in milestones.ics. | ||
| * | ||
| * Tagged local-only and excluded from the GitHub `PR Tests` gate | ||
| * (see .github/workflows/pr-tests.yml). It runs as part of the normal local | ||
| * suite — `./vendor/bin/sail artisan test` — so drift surfaces the moment you | ||
| * edit one file without the other, without gating PRs on a docs invariant. | ||
| */ | ||
| #[Group('local-only')] | ||
| class MilestoneScheduleConsistencyTest extends TestCase | ||
| { | ||
| public function test_plan_targets_match_ics_end_dates(): void | ||
| { | ||
| $icsEndDates = $this->icsEndDatesByMilestone(); | ||
| $planTargets = $this->planTargetsByMilestone(); | ||
|
|
||
| $this->assertNotEmpty($planTargets, 'No milestone rows parsed from PLAN.md active table.'); | ||
|
|
||
| foreach ($planTargets as $id => $target) { | ||
| $this->assertArrayHasKey( | ||
| $id, | ||
| $icsEndDates, | ||
| "PLAN.md lists MS{$id} but milestones.ics has no matching event." | ||
| ); | ||
|
|
||
| $this->assertSame( | ||
| $icsEndDates[$id], | ||
| $target, | ||
| "MS{$id}: PLAN.md Target ({$target}) != milestones.ics end date ({$icsEndDates[$id]})." | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| /** @return array<int,string> milestone number => end date (Y-m-d) */ | ||
| private function icsEndDatesByMilestone(): array | ||
| { | ||
| $ics = file_get_contents(base_path('docs/milestones.ics')); | ||
|
|
||
| preg_match_all('/BEGIN:VEVENT(.*?)END:VEVENT/s', $ics, $blocks); | ||
|
|
||
| $endDates = []; | ||
|
|
||
| foreach ($blocks[1] as $block) { | ||
| if (! preg_match('/SUMMARY:MS(\d+)/', $block, $summary)) { | ||
| continue; | ||
| } | ||
|
|
||
| if (! preg_match('/DTEND;VALUE=DATE:(\d{8})/', $block, $dtend)) { | ||
| continue; | ||
| } | ||
|
|
||
| $endDates[(int) $summary[1]] = \DateTime::createFromFormat('Ymd', $dtend[1])->format('Y-m-d'); | ||
| } | ||
|
|
||
| return $endDates; | ||
| } | ||
|
|
||
| /** @return array<int,string> milestone number => Target date (Y-m-d) */ | ||
| private function planTargetsByMilestone(): array | ||
| { | ||
| $plan = file_get_contents(base_path('docs/PLAN.md')); | ||
|
|
||
| $section = Str::between($plan, '## Active and Upcoming Milestones', '## Completed Milestones'); | ||
|
|
||
| $targets = []; | ||
|
|
||
| foreach (preg_split('/\R/', $section) as $line) { | ||
| // Table rows look like: | [ ] | 19 | name | intent | 2026-07-18 | doc | | ||
| if (! preg_match('/^\|\s*\[.?\]\s*\|/', $line)) { | ||
| continue; | ||
| } | ||
|
|
||
| $cells = array_map('trim', explode('|', $line)); | ||
|
|
||
| // explode leaves an empty leading cell; columns: 1=status 2=id ... 5=Target | ||
| if (! ctype_digit($cells[2] ?? '') || ! preg_match('/^\d{4}-\d{2}-\d{2}$/', $cells[5] ?? '')) { | ||
| continue; | ||
| } | ||
|
|
||
| $targets[(int) $cells[2]] = $cells[5]; | ||
| } | ||
|
|
||
| return $targets; | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This updated timing still puts the LLC phase completion after the new MS19 close: the strategy says the serial CyberCreek → CryptoZing formation/publication path lands around 2026-07-20, while the canonical calendar in this commit closes MS19 on 2026-07-18 and the phase exit criteria still require CryptoZing publication to be complete. In that schedule, MS19 can reach its planned close before this required phase can finish, so either the MS19 window needs to move past ≈7/20 or publication needs to be explicitly moved out of MS19 exit criteria.
Useful? React with 👍 / 👎.