Skip to content

Feat/add import consumes#124

Merged
jlouvel merged 1 commit intomainfrom
feat/add-import-consumes
Mar 13, 2026
Merged

Feat/add import consumes#124
jlouvel merged 1 commit intomainfrom
feat/add-import-consumes

Conversation

@eskenazit
Copy link
Contributor

@eskenazit eskenazit commented Mar 11, 2026

added consumes import support and made some chore cleaning

@eskenazit eskenazit requested review from farah-t-trigui and jlouvel and removed request for farah-t-trigui March 11, 2026 17:24
@jlouvel
Copy link
Contributor

jlouvel commented Mar 11, 2026

@eskenazit I've added the implementation to this PR to streamline the review process. I have only left out the "operations" surcharge feature for now.

@jlouvel jlouvel mentioned this pull request Mar 11, 2026
Open
eskenazit
eskenazit commented Mar 12, 2026
View reviewed changes
@eskenazit
Copy link
Contributor Author

eskenazit commented Mar 12, 2026

@jlouvel since this is my own PR, I cannot approve or request for changes for your submissions. Let us discuss this in the retrospective to have a proper process in this case =)

jlouvel
jlouvel reviewed Mar 12, 2026
View reviewed changes
Copy link
Contributor

@jlouvel jlouvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eskenazit Argh, I didn't anticipate that.. I have rebased and fixed issues. Should I approve?

@jlouvel jlouvel requested review from jeremnaf and jlouvel March 12, 2026 13:02
jlouvel
jlouvel previously approved these changes Mar 12, 2026
View reviewed changes
Copy link
Contributor

@jlouvel jlouvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eskenazit eskenazit dismissed jlouvel’s stale review March 12, 2026 14:08

The merge-base changed after approval.

@jeremnaf
Copy link
Contributor

jeremnaf commented Mar 12, 2026

Do you want me to approve and merge this PR @eskenazit @jlouvel ?

@eskenazit
Copy link
Contributor Author

eskenazit commented Mar 12, 2026

@jeremnaf when it's ready yes, but it is not yet ^^'

eskenazit
eskenazit commented Mar 12, 2026
View reviewed changes
Copy link
Contributor Author

@eskenazit eskenazit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jlouvel still a few things to fix

@jlouvel
Copy link
Contributor

jlouvel commented Mar 12, 2026

@eskenazit I've removed the tutorial step 7 and associated YAML file. This is delayed this PR and has little value at this point

@eskenazit
Copy link
Contributor Author

eskenazit commented Mar 13, 2026

@jeremnaf this should be OK now =)

jeremnaf
jeremnaf previously approved these changes Mar 13, 2026
View reviewed changes
Copy link
Contributor

@jeremnaf jeremnaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eskenazit eskenazit dismissed jeremnaf’s stale review March 13, 2026 12:14

The merge-base changed after approval.

@eskenazit eskenazit requested a review from jlouvel March 13, 2026 12:18
jlouvel
jlouvel previously approved these changes Mar 13, 2026
View reviewed changes
Copy link
Contributor

@jlouvel jlouvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eskenazit eskenazit dismissed jlouvel’s stale review March 13, 2026 12:20

The merge-base changed after approval.

@jlouvel jlouvel mentioned this pull request Mar 13, 2026
Closed
@jlouvel jlouvel requested review from jeremnaf and jlouvel March 13, 2026 16:44
jlouvel
jlouvel previously approved these changes Mar 13, 2026
View reviewed changes
Copy link
Contributor

@jlouvel jlouvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eskenazit eskenazit dismissed jlouvel’s stale review March 13, 2026 16:45

The merge-base changed after approval.

@jlouvel jlouvel requested review from jlouvel and removed request for jeremnaf March 13, 2026 16:45
jlouvel
jlouvel previously approved these changes Mar 13, 2026
View reviewed changes
Copy link
Contributor

@jlouvel jlouvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eskenazit eskenazit dismissed jlouvel’s stale review March 13, 2026 16:50

The merge-base changed after approval.

@eskenazit eskenazit requested a review from jeremnaf March 13, 2026 16:51
jeremnaf
jeremnaf previously approved these changes Mar 13, 2026
View reviewed changes
Copy link
Contributor

@jeremnaf jeremnaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eskenazit eskenazit dismissed jeremnaf’s stale review March 13, 2026 16:55

The merge-base changed after approval.

jeremnaf
jeremnaf previously approved these changes Mar 13, 2026
View reviewed changes
Copy link
Contributor

@jeremnaf jeremnaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eskenazit eskenazit dismissed jeremnaf’s stale review March 13, 2026 17:01

The merge-base changed after approval.

jeremnaf
jeremnaf approved these changes Mar 13, 2026
View reviewed changes
Copy link
Contributor

@jeremnaf jeremnaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlouvel
feat: add global consumes import support
ade3b6a 
- Add ConsumesImportResolver to resolve imported consumes definitions
- Add ImportedConsumesHttpSpec for imported HTTP client specs
- Add ClientSpecDeserializer for polymorphic deserialization
- Extend NaftikoSpec and Capability to wire import resolution
- Update naftiko-schema.json with consumes import schema
- Add integration tests: CapabilityImportIntegrationTest, ConsumesImportResolverTest
- Add unit test: ClientSpecDeserializerTest
- Update tutorial examples to use updated schema reference
@jlouvel jlouvel force-pushed the feat/add-import-consumes branch from b5cb600 to ade3b6a Compare March 13, 2026 17:22
@jlouvel jlouvel merged commit 6a13c9f into main Mar 13, 2026
6 checks passed
@jlouvel jlouvel deleted the feat/add-import-consumes branch March 13, 2026 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jlouvel jlouvel jlouvel approved these changes

@jeremnaf jeremnaf jeremnaf approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eskenazit @jlouvel @jeremnaf