IS-3017: Log error message søk #585
Merged
+86
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eirikdahlen
approved these changes
Jan 29, 2025
Comment on lines
+68
to
+116
| function logSokPersonError({ | ||
| birthdate, | ||
| isValidBirthdate, | ||
| isInvalidBirthdate, | ||
| initials, | ||
| isValidInitials, | ||
| isInvalidInitials, | ||
| isError, | ||
| }: LogSokPersonErrorProps) { |
There was a problem hiding this comment.
Kunne kanskje sluppet unna mange inputparametere dersom funksjonen lå inne i komponenten og brukte de direkte derfra, men det blir kanskje litt smak og behag hvordan vi ønsker å bygge opp komponenten 🤔
ingring
force-pushed
the
IS-3017-log-error-message-sok
branch
3 times, most recently
from
8fa1039 to
73123d6
Compare
ingring
force-pushed
the
IS-3017-log-error-message-sok
branch
from
73123d6 to
9e1d397
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hva har blitt lagt til✨🌈