Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IS-3017: Log error message søk #585

Merged
merged 1 commit into from
Jan 30, 2025
Merged

IS-3017: Log error message søk #585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 74 additions & 0 deletions src/sider/sokperson/SokPerson.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,71 @@ function logSokPersonResults(amount: number, requestDTO: SokDTO) {
});
}

interface LogSokPersonErrorProps {
birthdate: string;
isValidBirthdate: boolean;
isInvalidBirthdate: boolean;
initials: string;
isValidInitials: boolean;
isInvalidInitials: boolean;
isError: boolean;
}

function logSokPersonError({
birthdate,
isValidBirthdate,
isInvalidBirthdate,
initials,
isValidInitials,
isInvalidInitials,
isError,
}: LogSokPersonErrorProps) {
Comment on lines +108 to +116
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kunne kanskje sluppet unna mange inputparametere dersom funksjonen lå inne i komponenten og brukte de direkte derfra, men det blir kanskje litt smak og behag hvordan vi ønsker å bygge opp komponenten 🤔

Amplitude.logEvent({
type: Amplitude.EventType.ErrorMessageShowed,
data: {
url: window.location.href,
handling: 'Søk etter sykmeldt - feilmeldinger',
feilmelding:
'Fødselsdato: ' +
getValidationMessage({
value: birthdate,
isValid: isValidBirthdate,
isInvalid: isInvalidBirthdate,
}) +
' - Initialer: ' +
getValidationMessage({
value: initials,
isValid: isValidInitials,
isInvalid: isInvalidInitials,
}) +
(isError ? ' - Feil ved søk' : ''),
},
});
}

interface ValidationArgs {
value: string;
isValid: boolean;
isInvalid: boolean;
}

function getValidationMessage({
value,
isValid,
isInvalid,
}: ValidationArgs): string {
if (value === '') {
return 'ingen innhold';
}
if (isValid) {
return 'gyldig innhold';
}
if (isInvalid) {
return 'ugyldig innhold';
}
return '';
}

function InitialerLabel() {
return (
<div className="flex gap-2">
Expand Down Expand Up @@ -165,6 +230,15 @@ export default function SokPerson() {
});
} else {
setIsFormError(true);
logSokPersonError({
birthdate: birthdate,
isValidBirthdate: !!parsedBirthdate,
isInvalidBirthdate: isInvalidBirthdate,
initials: initials,
isValidInitials: isValidInitials(initials),
isInvalidInitials: isInvalidInitials,
isError: isError,
});
}
};

Expand Down
13 changes: 12 additions & 1 deletion src/utils/amplitude.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ export enum EventType {
ButtonClick = 'knapp trykket',
SortingColumn = 'kolonne sortert på',
AmountDisplayed = 'antall vist',
ErrorMessageShowed = 'feilmelding vist',
}

type EventPageView = {
Expand Down Expand Up @@ -66,13 +67,23 @@ type EventAmountDisplayed = {
};
};

type ErrorMessageShowed = {
type: EventType.ErrorMessageShowed;
data: {
url: string;
handling: string;
feilmelding: string;
};
};

type Event =
| EventPageView
| Navigation
| OptionSelected
| EventButtonClick
| EventSortingColumn
| EventAmountDisplayed;
| EventAmountDisplayed
| ErrorMessageShowed;

export const logEvent = (event: Event) =>
amplitude.track(event.type, { ...event.data });
Expand Down