[Style]: Move BigInteger extensions from Utility to BigIntegerExtensions
#3916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shargon
reviewed
May 1, 2025
| } | ||
|
|
||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | ||
| private static int BitCount(byte w) |
There was a problem hiding this comment.
BitCount has changed, this should be done in a different pr
There was a problem hiding this comment.
OK, Submit this simpified implementation later.
Wi1l-B0t
force-pushed
the
style.move-bigint-extensions
branch
from
7412acf to
becb238
Compare
shargon
approved these changes
May 2, 2025
|
Why coverage decresed? |
NGDAdmin
pushed a commit
that referenced
this pull request
May 6, 2025
* optimize: show native contract net active yet * Update src/Neo.CLI/CLI/MainService.Native.cs * style: move BigInteger extensions from Utility to BigIntegerExtensions (#3916) --------- Co-authored-by: Shargon <[email protected]>
14 tasks
shargon
added a commit
that referenced
this pull request
May 12, 2025
* [`Optimize`]: show native contract is active or not (#3922) * optimize: show native contract net active yet * Update src/Neo.CLI/CLI/MainService.Native.cs * style: move BigInteger extensions from Utility to BigIntegerExtensions (#3916) --------- Co-authored-by: Shargon <[email protected]> * Avoid empty snupkg in release (#3925) * v3.8.1 (#3930) * Revert workflow branch --------- Co-authored-by: Will <[email protected]> Co-authored-by: Shargon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Just move BigInteger extensions from Utility to BigIntegerExtensions.
Checklist: