NEP-25 #4043
Open
NEP-25 #4043
+844
−70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajara87
approved these changes
Jul 2, 2025
Jim8y
reviewed
Jul 19, 2025
shargon
commented
Jul 29, 2025
shargon
commented
Jul 29, 2025
This reverts commit d392f50.
shargon
commented
Jul 30, 2025
ajara87
previously approved these changes
Jul 31, 2025
- Document all implemented features and components - Add usage examples for different type definitions - Confirm backward compatibility with NEP-14 - Mark implementation as complete and tested
- Update FromStackItem_ShouldHandleNullFields test to include all 8 fields - Update ToStackItem_ShouldProduceNullFields test to expect 8 fields - Tests now match the actual ExtendedType implementation which uses 8 fields
|
@neo-project/core ready to review again |
|
Ping @neo-project/core |
cschuchardt88
previously approved these changes
Sep 17, 2025
| if (ExtendedReturnType != null) | ||
| { | ||
| item.Add(ExtendedReturnType.ToStackItem(referenceCounter)); | ||
| } |
There was a problem hiding this comment.
Looks like a bit inconsistent encoding, we add NULL stackitem for missing NamedTypes, but do not add it for missing ExtendedReturnType. Should work both ways, but I'd prefer some unified approach to new fields. Same thing with other types.
|
|
||
| internal StackItem ToStackItem(IReferenceCounter referenceCounter, Struct array) | ||
| { | ||
| array.Add((byte)Type); |
There was a problem hiding this comment.
What do you think of using map type for stack item encoding? Array-based encoding always requires 8 elements, but in practice the most typical number of active elements is 2 (type+smth), more rarely 3, in a map that'd be 4-6 stack items. I'm a little concerned about big manifests (like in #3802).
| var startIndex = 0; | ||
| Type = (ContractParameterType)(byte)array[startIndex++].GetInteger(); | ||
| if (!Enum.IsDefined(typeof(ContractParameterType), Type)) throw new FormatException("Incorrect Type"); | ||
| if (Type == ContractParameterType.Void) throw new FormatException("Void Type is not allowed in NEP-25"); |
There was a problem hiding this comment.
NEP-25 technically doesn't forbid that, the type can be used as method return type. In which case ExtendedType is useless as it can't contain any other data but the same type, but still valid.
| if (!Enum.IsDefined(typeof(ContractParameterType), Type)) throw new FormatException(); | ||
| NamedType = array[startIndex++].GetString(); | ||
|
|
||
| if (array[startIndex++] is Integer length) |
There was a problem hiding this comment.
Optional, but what if array[startIndex++] is a map, for example?
| { | ||
| Fields = null; | ||
| } | ||
| } |
There was a problem hiding this comment.
The question is more about semantic checks, almost all fields are optional, but not all combinations of fields are valid. This is described in NEP-25 and both deserialization methods should check for it.
|
Need a hardfork. So many incompatible data are there. Compared full mainnet node sync with #4167 and #4043, here's the result. |
|
I think that's related to #4043 (comment), if we're to not encode missing fields at all stack item representation will be the same for old (NEP-14) manifests. |
This was referenced Oct 3, 2025
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement NEP-25 neo-project/proposals#160 (review)
Replace of #3272
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: