[Fix] Output Only Needed Dependencies For Plugins

[cschuchardt88]

Description

Needs PR #4225

Fixed the whole project

• Added $(PluginOutDir) msbuild property for easy CI work with build targets.
• No more un needed dll in the OutDir for plugins
• Updated CI workflow to reflect this PR.

CI Release output will look like this:

https://github.com/cschuchardt88/neo/releases/tag/v3.9.2
Hint: Extract the files to see.

Type of change

• Optimization (the change is only an optimization)
• Style (the change is only a code style for better maintenance or standard purpose)
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

• Test A
• Test B

Test Configuration:

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[shargon]

@superboyiii could you test it, the change seems good to me

[cschuchardt88]

next step is to output dlls to neo-cli plugins folder after this pr.

[superboyiii]

@superboyiii could you test it, the change seems good to me

Sure

[superboyiii]

Actually some removed dependencies are needed, for example, grpc for OralceService, Swagger related dlll for RestServer. I know this could make it clean but some of the plugins will not work without these dependencies.

[cschuchardt88]

Actually some removed dependencies are needed, for example, grpc for OralceService, Swagger related dlll for RestServer. I know this could make it clean but some of the plugins will not work without these dependencies.

they're if you publish

[superboyiii]

Actually some removed dependencies are needed, for example, grpc for OralceService, Swagger related dlll for RestServer. I know this could make it clean but some of the plugins will not work without these dependencies.

they're if you publish

I know. But I'm not sure what's this PR aims to? If we'd like to simplify dependency generation as much as possible without affecting functionality and it's able to be debugged after building. If this is our purpose, apparently this PR is not on that way.

[cschuchardt88]

Actually some removed dependencies are needed, for example, grpc for OralceService, Swagger related dlll for RestServer. I know this could make it clean but some of the plugins will not work without these dependencies.

they're if you publish

I know. But I'm not sure what's this PR aims to? If we'd like to simplify dependency generation as much as possible without affecting functionality and it's able to be debugged after building. If this is our purpose, apparently this PR is not on that way.

fixed

[superboyiii]

Why we remove basic plugins (LevelDB, RocksDB) in CLI‘s bin? It's a good feature before but now they're not there anymore.

[superboyiii]

Somewhere is incorrect, I can't start CLI this time:

Already added libleveldb.dll and Plugins, they should be there before.
I can start dev CLI, so it's not my environment's fault.

By the way, I always have Microsoft Visual C++ Redistributable

[cschuchardt88]

@superboyiii fixed now

[superboyiii]

Why we copy these empty Plugin folders into CLI when building completed?

[cschuchardt88]

Why we copy these empty Plugin folders into CLI when building completed?

It shouldnt be empty. There should be all the files in there. You must not be building it right.

[superboyiii]

No LevelDB or RocksDB plugin in CLI bin path now...

[vncoelho]

@cschuchardt88

Commit fe5d285 needs to be done in this PR or is generic?

[vncoelho]

@cschuchardt88, there are some problems with the plugins.

I checked again dev branch and here introduces some errors, maybe due to config files or something else.

I will double check.

But for now I see that there are compatibilities problems

[vncoelho]

I see here, some plugins were not copied, for example.

AppplicationLogs, OracleService, TokensTracker, StateService

[vncoelho]

No LevelDB or RocksDB plugin in CLI bin path now...

The same here @superboyiii , problems with some plugins

[cschuchardt88]

No LevelDB or RocksDB plugin in CLI bin path now...

The same here @superboyiii , problems with some plugins

Ill look into it again.

In the meantime try this

dotnet clean
dotnet restore
dotnet build
dotnet run --project ./src/Neo.CLI/

[cschuchardt88]

needs #4225

[cschuchardt88]

needs #4225

#4225 is no longer needed for this PR to work. However, unmanaged DLLs won't load until it is merged. But its still ok to merge this PR.

[shargon]

Why we need to modify the tests packages?

[cschuchardt88]

All class library projets don't allow the parent to inherit from it! Also if you are using a class from a library and its not included in your project you shouldn't depend on another libraries to include it as a sub-library. Also it will include it in the output!!