BUGFIX: Support ORM attributes

[kdambekalns]

Hopefully fixes #2602 and allows to use PHP attributes to configure Doctrine ORM, not only annotations like before.

Upgrade instructions

No change should be needed.

Checklist

• Code follows the PSR-2 coding style
• Tests have been created, run and adjusted as needed
• The PR is created against the lowest maintained branch
• Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
• Reviewer - The first section explains the change briefly for change-logs
• Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

[kdambekalns]

This does not yet work – whether this "minimally invasive" approach is feasible is yet to be proven…

[kdambekalns]

@mficzel Using the reflection service in our own reader implementation works.

If our assumptions are correct, new tests should pass, too.

[mficzel]

@kdambekalns something is still fishy ...

Doctrine\ORM\Mapping\MappingException: No identifier/primary key specified for Entity "Neos\Flow\Tests\Functional\Persistence\FixturesPHP8\AnnotatedIdEntity" sub class of "Neos\Flow\Tests\Functional\Persistence\FixturesPHP8\AnnotatedIdEntity_Original". Every Entity must have an identifier/primary key.

/var/www/html/Packages/Libraries/doctrine/orm/src/Mapping/MappingException.php:44
/var/www/html/Packages/Libraries/doctrine/orm/src/Mapping/ClassMetadataInfo.php:1194
/var/www/html/Packages/Libraries/doctrine/orm/src/Mapping/ClassMetadataFactory.php:284
/var/www/html/Packages/Libraries/doctrine/orm/src/Mapping/ClassMetadataFactory.php:264
/var/www/html/Packages/Libraries/doctrine/persistence/src/Persistence/Mapping/AbstractClassMetadataFactory.php:343
/var/www/html/Packages/Libraries/doctrine/persistence/src/Persistence/Mapping/AbstractClassMetadataFactory.php:207
/var/www/html/Packages/Libraries/doctrine/persistence/src/Persistence/Mapping/AbstractClassMetadataFactory.php:96
/var/www/html/Data/Temporary/Testing/Cache/Code/Flow_Object_Classes/Neos_Flow_Persistence_Doctrine_PersistenceManager.php:317
/var/www/html/Packages/Framework/Neos.Flow/Tests/FunctionalTestCase.php:159

[mficzel]

I wonder wether we also have to adjust \Neos\Flow\Persistence\Doctrine\Mapping\ClassMetadata->_initializeReflection

[kdambekalns]

Making @Flow\Entity an attribute in "real code" within the Flow classes allows a clean compile run. And #[ORM\Id] and #[Flow\Identity] do work, too. So, is only testing affected?

[kdambekalns]

Doh… I removed all the adjusted entities except AnnotatedIdEntity to limit the scope. Turns out this is broken:

#[Flow\Entity]
class AnnotatedIdEntity
{
    #[ORM\Id]
    #[ORM\GeneratedValue]
    #[ORM\SequenceGenerator(sequenceName: 'annotatedidentity_seq')]
    protected string $id;

But this does work:

#[Flow\Entity]
class AnnotatedIdEntity
{
    /** @var string */
    #[ORM\Id]
    #[ORM\GeneratedValue]
    #[ORM\SequenceGenerator(sequenceName: 'annotatedidentity_seq')]
    protected string $id;

The missing @var breaks it! On to digging deeper…

[mficzel]

We should think about targeting Neos 8.4 + PHP 8.2 as i noticed that in Neos 8.3 with PHP 8.0 we:

• Cannot declare nested attributes in PHP as those are a PHP 8.1 feature
• Even with PHP 8.2 + Neos 8.3 Nested Attributes are destroyed by the proxy class builder. I hope this is better in 8.4

[mficzel]

Checked Neos 8.4 and the proxy builder still destroys nested attributes. Created #3511 for that.

[kdambekalns]

I am confused. Locally this PR passes on PHP 8.3 if I add this:
var-annotations.patch

How does this relate to broken attribute rendering?

• In the sense it will never work on PHP 8.0 and 8.1, and the solution is to go for Flow 8.4, as that requires PHP 8.2? Fine with me!
• But that will not automagically fix the "missing type issue", or is that something that has changed in Flow 8.4 already?

[mficzel]

I tried rebasing this pr to 8.4 and together with the changes from #3512 i could successfully define a repository and entity via attributes.

However the properties in the entity were not detected unless i added the @var annotation. So this problem persists even in 8.4.

However it looks like it might really be the last real problem as the proxy classes were successfully created otherwise and flow did not complain about anything.

[kdambekalns]

However it looks like it might really be the last real problem as the proxy classes were successfully created otherwise and flow did not complain about anything.

That's great news already!

[kdambekalns]

🎉