BUGFIX: Handle enums and attributes (Objects) in attribute arguments for proxy classes #3512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mficzel
force-pushed
the
bugfix/nestedAttributeSupportForProxyClasses
branch
2 times, most recently
from
572c495 to
6feb72b
Compare
…ibutes during proxy building
mficzel
force-pushed
the
bugfix/nestedAttributeSupportForProxyClasses
branch
2 times, most recently
from
42949ba to
a37bea6
Compare
The code generated by var_export for objects (and enums) is not valid to be used in attributes as those require a constant expression. This change addresses that by: - rendering Enums correctly - rendering other objects by filling constructor arguments with public property or getter values - handling array arguments by calling the above recursively
mficzel
force-pushed
the
bugfix/nestedAttributeSupportForProxyClasses
branch
4 times, most recently
from
045e04f to
4251d77
Compare
mficzel
changed the title
This is done by using the method Compiler::renderAttribute instead of a local implementation
mficzel
force-pushed
the
bugfix/nestedAttributeSupportForProxyClasses
branch
from
4251d77 to
34c8208
Compare
|
Please Note: This change reverts a change from the proxyMethod builder that used the Compiler::renderAttribute in 8.3 but got its own methods for that in 8.4. I am not sure why as the logic is a bit tricky and it should be beneficial to only have one source of issues. |
robertlemke
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle Enums nested Attributes (actually any Objects) in attribute arguments for proxy classes.
Currently the Attributes for generated proxy classes have some limitations:
This change addresses that by:
!!! This on itself does not add attribute support for persistence. See #3508 for that !!!
resolves: #3511
relates: #3075
Upgrade instructions
No changes are needed only cases that previously yielded errors should work now.
Review instructions
The inference of constructor arguments from values obtained via ObjectAccess is close but not perfect. However it works in the cases we want to support like Doctrine Table Attributes and probably most other cases aswell.
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions