[JGAntunes]

🎉 Thanks for submitting a pull request! 🎉

Summary

Fixes COM-209 - https://linear.app/netlify/issue/COM-209/reloading-issues-with-edge-function-files-when-using-cli-netlify-dev. The way we currently process the dependency graph of edge function is limited to the direct dependencies of it. This PR changes it to perform a depth first search and build a full depedency list for a given function.

Keeping it as draft as I would love to add a test for it but unsure what would be the best way to go about it? 🤔 Any ideas? Maybe @Skn0tt?

---

For us to review and ship your PR efficiently, please perform the following steps:

• Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
• Read the contribution guidelines 📖. This ensures your code follows our style guide and
  passes our tests.
• Update or add tests (if any source code was changed or added) 🧪
• Update or add documentation (if features were changed or added) 📝
• Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

[github-actions]

📊 Benchmark results

Comparing with a4b7449

• Dependency count: 1,410 (no change)
• Package size: 422 MB (no change)
• Number of ts-expect-error directives: 1,182 (no change)

[Skn0tt]

The rough problem seems to be that we were only checking one level-deep dependencies. I haven't fully grasped the change you're proposing here, but traversing the full module graph seems to be the right solution.

As for adding a test, I'd add a case similar to

cli/tests/integration/commands/dev/edge-functions.test.ts

Lines 135 to 152 in 3379f40

	setupFixtureTests('dev-server-with-edge-functions', { devServer: true, mockApi: { routes } }, () => {
	test<FixtureTestContext>('should not remove other edge functions on change', async ({ devServer, fixture }) => {
	// we need to wait till file watchers are loaded
	await pause(500)
	await fixture.builder
	.withEdgeFunction({
	name: 'new',
	handler: async () => new Response('hello'),
	config: { path: ['/new'] },
	})
	.build()
	await devServer.waitForLogMatching('Loaded edge function new')
	expect(devServer.output).not.toContain('Removed edge function')
	})
	})

, where a fixture with a nested dependency is built, then you make some assertions, then you change the nested dependency and assert again. Maybe you also add an assertion on the logs to ensure it prints Reloading function.

[Skn0tt]

I've added a test, refactored the code to make it a bit more concise, and added a couple other small refactorings. @JGAntunes would love your review!

[JGAntunes]

Can't approve because I kicked of the PR 😅 but LGTM