update go version #39
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahegdeNR
requested changes
Jul 3, 2025
There was a problem hiding this comment.
@sanathramesh can you modify all the workflows to use the same go version?
maya-jha
requested changes
Jul 3, 2025
| go 1.22.0 | ||
|
|
||
| toolchain go1.23.0 | ||
| go 1.24.4 |
There was a problem hiding this comment.
also update InstrumentationVersion https://github.com/newrelic/aws-unified-lambda/blob/b43d7eb0dd61f08809cf7a1ecb65f4f181f80c02/src/common/version.go#L5
There was a problem hiding this comment.
We don't need toolchain anymore?
There was a problem hiding this comment.
If we update instrumentation version, then tests also need to be updated with same
There was a problem hiding this comment.
no toolchain needed.
I have updated the patch version.
ahegdeNR
previously approved these changes
Jul 9, 2025
ahegdeNR
previously approved these changes
Jul 9, 2025
ahegdeNR
previously approved these changes
Jul 9, 2025
ahegdeNR
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go version upgrade to 1.24.4