Skip to content

update go version #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pull_request.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ jobs:
- name: Setup Go
uses: actions/setup-go@v5
with:
go-version: '1.22'
go-version: '1.24.4'
#scripts to include the integration and end to end tests should be added here
- name: Run Test Cases and Coverage
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release-lambda-code.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
- name: Setup Go
uses: actions/setup-go@v5
with:
go-version: '1.22'
go-version: '1.24.4'

- name: Build and Package Go executable
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release-template-files.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
- name: Setup Go
uses: actions/setup-go@v5
with:
go-version: '1.22'
go-version: '1.24.4'

- name: Install AWS SAM CLI
run: |
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/run-e2e-tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
- name: Setup Go
uses: actions/setup-go@v5
with:
go-version: '1.22'
go-version: '1.24.4'

- name: Install AWS SAM CLI
run: |
Expand Down Expand Up @@ -79,7 +79,7 @@ jobs:
- name: Setup Go
uses: actions/setup-go@v5
with:
go-version: '1.22'
go-version: '1.24.4'

- name: Install AWS SAM CLI
run: |
Expand Down Expand Up @@ -129,7 +129,7 @@ jobs:
- name: Setup Go
uses: actions/setup-go@v5
with:
go-version: '1.22'
go-version: '1.24.4'

- name: Install AWS SAM CLI
run: |
Expand Down Expand Up @@ -176,7 +176,7 @@ jobs:
- name: Setup Go
uses: actions/setup-go@v5
with:
go-version: '1.22'
go-version: '1.24.4'

- name: Install AWS SAM CLI
run: |
Expand Down
2 changes: 1 addition & 1 deletion e2e-tests/common-scripts/entity_synthesis_param.cfg
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Entity synthesis Parameters , aws related params are dropped in pipeline.
instrumentation_provider=aws
instrumentation_name=lambda
instrumentation_version=1.1.0
instrumentation_version=1.1.1
2 changes: 1 addition & 1 deletion integration-tests/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,4 @@ require (

module github.com/newrelic/aws-unified-lambda-logging

go 1.22
go 1.24.4
2 changes: 1 addition & 1 deletion src/common/version.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
package common

// InstrumentationVersion is a parameter necessary for Entity Synthesis at New Relic.
const InstrumentationVersion = "1.1.0"
const InstrumentationVersion = "1.1.1"
4 changes: 1 addition & 3 deletions src/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,4 @@ require (

module github.com/newrelic/aws-unified-lambda-logging

go 1.22.0

toolchain go1.23.0
go 1.24.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also update InstrumentationVersion https://github.com/newrelic/aws-unified-lambda/blob/b43d7eb0dd61f08809cf7a1ecb65f4f181f80c02/src/common/version.go#L5

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need toolchain anymore?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we update instrumentation version, then tests also need to be updated with same

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no toolchain needed.
I have updated the patch version.

Loading