Feature/4712/add participant to1to1

[mahibi]

resolve #4712

Screenshots

How to test

• In web, add participants to 1-to-1 in a chat -> push notification should appear on android
• In web, add participants to 1-to-1 in a call -> call should switch on android
• In android, go to 1to1 conversation - conversation info - In particiapnts section, click "Start group chat" -> Chat is created and opened on android.

TODO

• check param values for CreateRoomRequest ?
• check capability conversation-creation-all
• align room name (sorting of participants?)
  • main actors first makes sense to me
• implement add participants picker for call screen. Will be done in a followup PR (In "worst case" it requires a service implementation for calls..)

🏁 Checklist

• ⛑️ Tests (unit and/or integration) are included or not needed
• 🔖 Capability is checked or not needed
• 🔙 Backport requests are created or not needed: /backport to stable-xx.x
• 📅 Milestone is set
• 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

[mahibi]

Note to myself for testing (with HPB):

json for curl request (replace objectId with old room token):

{
  "objectType": "extend_conversation",
  "objectId": "5873149015",
  "roomName": "Hi",
  "participants": {
    "users": [
      "admin",
      "user1",
      "user2"
    ]
  }
}

curl:

curl -k -u admin:admin https://nextcloudlocal/ocs/v2.php/apps/spreed/api/v4/room -X POST -H 'OCS-APIRequest: true' -d @extend.json -H 'Content-Type: application/json'

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4826-talk.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	98	98
Errors	9	9

SpotBugs

Category	Base	New
Bad practice	6	6
Correctness	222	117
Dodgy code	71	71
Internationalization	3	3
Malicious code vulnerability	3	3
Performance	4	4
Security	1	1
Total	310	205

[sowjanyakch]

@mahibi - tested this.
Some minor comments - Sometimes user name appears twice in the conversation name (same on web). When a user is removed from the conversation, we can update the conversation name (remove the participant from conversation name).

[mahibi]

Sometimes user name appears twice in the conversation name (same on web).

I can only reproduce this on web (fyi @Antreesy )
But i can not reproduce when i create the conversation on android

When a user is removed from the conversation, we can update the conversation name (remove the participant from conversation name).

that won't be done

[Antreesy]

Thanks for noticing! Addressed in nextcloud/spreed#14897