-
Notifications
You must be signed in to change notification settings - Fork 19
XIOS: properly handle filename patterns #1011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
joewallwork
wants to merge
12
commits into
xios-postprocess-dims
Choose a base branch
from
issue898_xios-filename-patterns
base: xios-postprocess-dims
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
XIOS: properly handle filename patterns #1011
joewallwork
wants to merge
12
commits into
xios-postprocess-dims
from
issue898_xios-filename-patterns
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
9207a40 to
37aff6d
Compare
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XIOS: properly handle filename patterns
Fixes #935
Fixes #997
Fixes #898
Fixes #933
Makes #967 redundant
Refinement of #1002
Merges into #1010Merges into #1015
Task List
Change Description
This PR fixes several things related to how restarts and diagnostics are configured with XIOS:
Whilst file patterns are made consistent with what's used elsewhere in nextSIM-DG, the output filenames show the range of datetimes separated by a hyphen.
Test Description
Tests are updated to account for the new behaviour.
I decided to drop
XiosFile_testbecause it is no longer needed. This meant that we could drop the annoyingunittestspecial case. This is what gives the large number of lines removed.Documentation Impact
The XIOS documentation page has been updated accordingly.
Pre-Request Checklist