-
Notifications
You must be signed in to change notification settings - Fork 19
File behaviour for restarts and diagnostics (take 2) #1002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
de49974 to
83d6c40
Compare
83d6c40 to
7888b37
Compare
10 tasks
Contributor
Author
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
enhancement
New feature or request
ICCS
Tasks or reviews for the ICCS team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File behaviour for restarts and diagnostics (take 2)
Fixes #935
Fixes #977
Fixes #997
Fixes #898
Fixes #933
Fixes #1003
Makes #967 redundant
Task List
Change Description
This PR fixes several things related to how restarts and diagnostics are configured with XIOS:
xandydimensions, rather than the versions appended with_<dimName>. We account for this by assuming thatxandyimplyx_dimandy_dimif encountered in an input file.Whilst file patterns are made consistent with what's used elsewhere in nextSIM-DG, the output filenames show the range of datetimes separated by a hyphen.
Test Description
Both read and write tests are separated out for reading of different file types. This is what accounts for most of the lines changed.
Tests are updated to account for the new behaviour.
I decided to drop
XiosFile_testbecause it is no longer needed. This meant that we could drop the annoyingunittestspecial case.Documentation Impact
The XIOS documentation page has been updated accordingly.
Pre-Request Checklist